Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Insightly: Fix state date conversion bug #19356

Merged
merged 12 commits into from
Jan 17, 2023
Merged

🐛 Source Insightly: Fix state date conversion bug #19356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
088454f
[FIX] cursor cast
henriblancke Nov 3, 2022
d540b09
Merge branch 'master' into insightly-incremental-fix
henriblancke Nov 11, 2022
7490353
[UPD] bump version
henriblancke Nov 11, 2022
aeaa5d6
Merge branch 'master' into insightly-incremental-fix
vincentkoc Nov 13, 2022
986b086
[FIX] add pendulum dependency
henriblancke Nov 15, 2022
ea1c288
Merge branch 'master' into insightly-incremental-fix
vincentkoc Nov 15, 2022
9ae0120
auto-bump connector version
octavia-squidington-iii Nov 15, 2022
45b7285
Merge branch 'master' into insightly-incremental-fix
vincentkoc Nov 16, 2022
9b21fb8
Merge branch 'master' into insightly-incremental-fix
vincentkoc Dec 23, 2022
60cefe8
Merge branch 'master' into insightly-incremental-fix
vincentkoc Jan 5, 2023
15ccf7c
Merge branch 'master' into insightly-incremental-fix
sajarin Jan 5, 2023
332a147
Merge branch 'master' into insightly-incremental-fix
vincentkoc Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@
- name: Insightly
sourceDefinitionId: 38f84314-fe6a-4257-97be-a8dcd942d693
dockerRepository: airbyte/source-insightly
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.com/integrations/sources/insightly
icon: insightly.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6499,7 +6499,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-insightly:0.1.0"
- dockerImage: "airbyte/source-insightly:0.1.1"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/insightly"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-insightly/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_insightly ./source_insightly
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-insightly
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-insightly/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.2",
"pendulum==2.1.2",
]

TEST_REQUIREMENTS = [
Expand Down
6 changes: 5 additions & 1 deletion airbyte-integrations/connectors/source-insightly/source_insightly/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,11 @@ def request_params(

start_datetime = pendulum.parse(self.start_date)
if stream_state.get(self.cursor_field):
start_datetime = pendulum.parse(stream_state[self.cursor_field])
start_datetime_raw = stream_state[self.cursor_field]
if isinstance(start_datetime_raw, datetime):
start_datetime = start_datetime_raw
else:
start_datetime = pendulum.parse(stream_state[self.cursor_field])

# Add one second to avoid duplicate records and ensure greater than
params.update({"updated_after_utc": (start_datetime + timedelta(seconds=1)).strftime("%Y-%m-%dT%H:%M:%SZ")})
Expand Down
7 changes: 4 additions & 3 deletions docs/integrations/sources/insightly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ The connector is restricted by Insightly [requests limitation](https://api.na1.i

## Changelog

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------------------------------------------------------------------- |
| 0.1.0 | 2021-07-19 | | Release Insightly CDK Connector |
| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------------------------------------------------------- |
| 0.1.1 | 2022-11-11 | | Fix state date parse bug |
| 0.1.0 | 2022-10-19 | | Release Insightly CDK Connector |