Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎉 Add auto-detect schema changes option to connection UIs #19734

Merged
merged 13 commits into from
Dec 7, 2022
Merged

🪟 🎉 Add auto-detect schema changes option to connection UIs #19734

merged 13 commits into from
Dec 7, 2022

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Nov 22, 2022 •
edited
Loading

What

closes #17826

Screenshot 2022-11-29 at 3 37 35 PM

How

Adds a new field using a similar pattern to the schedule field.

I've made a note to add E2E coverage in #17936

Recommended reading order

  1. NonBreakingChangesPreferenceField.*
  2. ConnectionFormFields.tsx
  3. other

Note:

As of right now, the API on frontend-dev has not been updated to include all of these changes. I will update this comment when frontend-dev is sorted out. However, this PR can be tested against OSS as it stands with REACT_APP_AUTO_DETECT_SCHEMA_CHANGES=true

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 22, 2022
@teallarson teallarson force-pushed the teal/add-schema-changes-options-to-connections-uis branch from 6423d99 to 1738ba8 Compare November 23, 2022 15:22
@teallarson teallarson force-pushed the teal/add-schema-changes-options-to-connections-uis branch from 501372b to 891e593 Compare November 29, 2022 19:35
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 29, 2022
@teallarson teallarson mentioned this pull request Dec 1, 2022
Closed
1 task
@teallarson teallarson force-pushed the teal/add-schema-changes-options-to-connections-uis branch from c79e929 to c744935 Compare December 5, 2022 17:04
@teallarson teallarson marked this pull request as ready for review December 5, 2022 17:44
@teallarson teallarson requested a review from a team as a code owner December 5, 2022 17:44
@teallarson
Copy link
Contributor Author

teallarson commented Dec 6, 2022 •
edited
Loading

TODO: migrate to new way of setting the feature flag when that PR is merged
Done. Utilizing hook instead of env var now.

@teallarson teallarson force-pushed the teal/add-schema-changes-options-to-connections-uis branch from e2be6e2 to 1715a07 Compare December 6, 2022 21:10
edmundito
edmundito approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally for create connection, edit replication settings, refresh source schema, and cancel edit.

@teallarson teallarson merged commit ca67ee7 into master Dec 7, 2022
@teallarson teallarson deleted the teal/add-schema-changes-options-to-connections-uis branch December 7, 2022 19:10
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@edmundito edmundito edmundito approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto-detect schema changes option to create connection and replication settings pages
4 participants
@teallarson @edmundito @krishnaglick @octavia-squidington-iv