Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations #19860

akashkulk · 2022-11-29T00:31:28Z

github-actions · 2022-11-29T00:32:25Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (1)

Connector	Version	Changelog	Publish
`source-snowflake`	`0.1.26`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

akashkulk · 2022-11-29T00:33:08Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3569876006
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3569876006
🐛 https://gradle.com/s/gmqsldmjgo4do

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-11-29T00:36:33Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3569893139
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3569893139
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: Backward compatibility tests are disabled for version 0.4.25.
================= 13 passed, 6 skipped, 21 warnings in 15.54s ==================

akashkulk · 2022-11-29T00:37:54Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/3569899724
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/3569899724
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 23.40s ==================

akashkulk · 2022-11-29T00:38:14Z

/test connector=connectors/source-clickhouse

akashkulk · 2022-11-29T00:38:57Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/3569905422
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/3569905422
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 30.55s ==================

akashkulk · 2022-11-29T01:11:35Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3570072586
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3570072586
🐛 https://gradle.com/s/27b5fghohey5a

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-11-29T01:11:53Z

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3570074441
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3570074441
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 26.43s ==================

akashkulk · 2022-11-29T16:26:22Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3576028332
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3576028332
🐛

Build Failed

Test summary info:

Could not find result summary

VitaliiMaltsev

LGTM

akashkulk · 2022-11-30T22:31:38Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3587627375
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3587627375
🐛 https://gradle.com/s/kfjrfyy36npga

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-11-30T22:32:49Z

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3587634676
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3587634676
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     199     93    53%   35, 41-43, 48, 53, 59, 65, 71, 77-79, 98, 103-105, 111-113, 119-120, 125-126, 131, 137, 146-155, 161-166, 181, 205, 236, 242, 250-255, 263-268, 276-289, 294-300, 307-318, 325-341
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1569    350    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 23.48s ==================

akashkulk · 2022-11-30T22:59:22Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3587780370
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3587780370
🐛 https://gradle.com/s/movarmh6flqjo

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-11-30T23:17:00Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3587890099
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3587890099
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     199     93    53%   35, 41-43, 48, 53, 59, 65, 71, 77-79, 98, 103-105, 111-113, 119-120, 125-126, 131, 137, 146-155, 161-166, 181, 205, 236, 242, 250-255, 263-268, 276-289, 294-300, 307-318, 325-341
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1569    350    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: Backward compatibility tests are disabled for version 0.4.25.
================= 13 passed, 6 skipped, 21 warnings in 13.82s ==================

akashkulk · 2022-12-01T18:24:38Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3595427694
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3595427694
🐛 https://gradle.com/s/njn73u6zjv4zw

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-12-05T21:40:54Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3624229466
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3624229466
🐛 https://gradle.com/s/xw6edybpdzbce

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-12-05T23:26:31Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3624913327
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3624913327
🐛 https://gradle.com/s/ft3aq67v2g6fq

Build Failed

Test summary info:

Could not find result summary

akashkulk · 2022-12-06T00:05:42Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3625122804
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3625122804
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     199     93    53%   35, 41-43, 48, 53, 59, 65, 71, 77-79, 98, 103-105, 111-113, 119-120, 125-126, 131, 137, 146-155, 161-166, 181, 205, 236, 242, 250-255, 263-268, 276-289, 294-300, 307-318, 325-341
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1569    350    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 23.41s ==================

Refactor

666a203

octavia-squidington-iv added area/connectors Connector related issues connectors/source/snowflake labels Nov 29, 2022

akashkulk temporarily deployed to more-secrets November 29, 2022 00:32 Inactive

Merge branch 'master' into new_jdbc_sourceop_refac

979fe14

akashkulk temporarily deployed to more-secrets November 29, 2022 16:26 Inactive

akashkulk requested a review from rodireich November 29, 2022 17:50

akashkulk marked this pull request as ready for review November 29, 2022 17:50

akashkulk requested a review from a team as a code owner November 29, 2022 17:50

VitaliiMaltsev approved these changes Nov 29, 2022

View reviewed changes

Merge branch 'master' into new_jdbc_sourceop_refac

e11435d

akashkulk temporarily deployed to more-secrets November 30, 2022 00:50 Inactive

Merge branch 'master' into new_jdbc_sourceop_refac

693b22e

akashkulk temporarily deployed to more-secrets November 30, 2022 16:25 Inactive

rodireich approved these changes Nov 30, 2022

View reviewed changes

ryankfu approved these changes Nov 30, 2022

View reviewed changes

Merge branch 'master' into new_jdbc_sourceop_refac

2170112

akashkulk temporarily deployed to more-secrets November 30, 2022 22:33 Inactive

Merge branch 'master' into new_jdbc_sourceop_refac

b938e9f

akashkulk temporarily deployed to more-secrets December 1, 2022 18:26 Inactive

Merge branch 'master' into new_jdbc_sourceop_refac

6944dc5

akashkulk temporarily deployed to more-secrets December 5, 2022 21:42 Inactive

Merge branch 'master' into new_jdbc_sourceop_refac

b40d044

akashkulk temporarily deployed to more-secrets December 5, 2022 23:27 Inactive

akashkulk and others added 2 commits December 5, 2022 16:04

Fix build failures

692f824

Merge branch 'master' into new_jdbc_sourceop_refac

8cd83a4

akashkulk temporarily deployed to more-secrets December 6, 2022 00:07 Inactive

akashkulk merged commit 5d936cc into master Dec 6, 2022

akashkulk deleted the new_jdbc_sourceop_refac branch December 6, 2022 01:57

This was referenced Dec 6, 2022

Bump Airbyte version from 0.40.23 to 0.40.24 #20161

Closed

Bump Airbyte version from 0.40.23 to 0.40.24 #20206

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations #19860

Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations #19860

akashkulk commented Nov 29, 2022 •

edited

Loading

github-actions bot commented Nov 29, 2022 •

edited

Loading

✅ Sources (1)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev left a comment

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 1, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 5, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 5, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 6, 2022 •

edited by github-actions bot

Loading

Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations #19860

Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations #19860

Conversation

akashkulk commented Nov 29, 2022 • edited Loading

github-actions bot commented Nov 29, 2022 • edited Loading

Affected Connector Report

✅ Sources (1)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 29, 2022

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 29, 2022 • edited by github-actions bot Loading

Build Failed

VitaliiMaltsev left a comment

Choose a reason for hiding this comment

akashkulk commented Nov 30, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Nov 30, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 30, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Nov 30, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Dec 1, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Dec 5, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Dec 5, 2022 • edited by github-actions bot Loading

Build Failed

akashkulk commented Dec 6, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 29, 2022 •

edited

Loading

github-actions bot commented Nov 29, 2022 •

edited

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 29, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 30, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 1, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 5, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 5, 2022 •

edited by github-actions bot

Loading

akashkulk commented Dec 6, 2022 •

edited by github-actions bot

Loading