Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NormalizationRunnerFactory #19993

Closed
wants to merge 127 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
127 commits
Select commit Hold shift + click to select a range
fadad7f
updated IntegrationLauncherConfig.yaml and added to this class suport…
andriikorotkov Nov 24, 2022
7caa00c
updated minor remarks
andriikorotkov Nov 25, 2022
8c46fd3
updated minor remarks
andriikorotkov Nov 25, 2022
8c7f464
fixed minor remarks
andriikorotkov Nov 28, 2022
1d90e5d
added normalization data to the tests
andriikorotkov Nov 29, 2022
7f97179
fixed minor remarks
andriikorotkov Nov 29, 2022
980459c
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Nov 29, 2022
6360b55
removed NormalizationRunnerFactory
andriikorotkov Nov 29, 2022
e04c848
fixed remarks
andriikorotkov Nov 29, 2022
6a4bebb
Merge branch 'akorotkov/18232' of github.com:airbytehq/airbyte into a…
andriikorotkov Nov 29, 2022
a035df6
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Nov 29, 2022
cd65ebb
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Nov 29, 2022
7f72805
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Nov 30, 2022
f77d768
Merge branch 'akorotkov/18232' of github.com:airbytehq/airbyte into a…
andriikorotkov Nov 30, 2022
f1cf84d
fixed remarks
andriikorotkov Nov 30, 2022
0b0cfce
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Nov 30, 2022
d972133
fixed remarks
andriikorotkov Dec 1, 2022
f97da1d
updated acceptance tests
andriikorotkov Dec 1, 2022
ee82e54
updated acceptance tests
andriikorotkov Dec 2, 2022
d6203ba
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Dec 4, 2022
77fe436
updated check_images_exist.sh script
andriikorotkov Dec 4, 2022
3afde21
updated method for get normalization image name for destination accep…
andriikorotkov Dec 4, 2022
f91c1b1
fixed code style
andriikorotkov Dec 4, 2022
002d253
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
andriikorotkov Dec 5, 2022
48077f7
fixed code style and removed tests data
andriikorotkov Dec 5, 2022
f8136f4
🪟 🎉 Add options to tooltip of oneOf properties (#20015)
Dec 5, 2022
6e06ae7
fix: comment downtime sync test and restore helm ac tests (#19944)
xpuska513 Dec 5, 2022
ccc42c7
updated JobErrorReporterTest.java
andriikorotkov Dec 5, 2022
5149108
:bug: Source ElasticSearch: avoid too_long_frame_exception (#18134)
jeromedoucet Dec 5, 2022
57f5087
updated JobErrorReporterTest.java
andriikorotkov Dec 5, 2022
3a11c7e
Fix formatting typo octavia list` command" (#19213)
MaxiChef Dec 5, 2022
34e85e3
source-mailchimp: set primary_key for EmailActivity (#19023)
mdibaiee Dec 5, 2022
c471be2
🐛 Source RD Station Marketing: Fix stream analytics conversions (#18826)
sarafonseca-123 Dec 5, 2022
201df24
Enable PMD rule to prevent == string comparisons (#20080)
jdpgrailsdev Dec 5, 2022
92f71ac
Source RKI-Covid - add history data, incidence rate, cases, death, ho…
Zawar92 Dec 5, 2022
2a16285
remove un-used update/delete custom connector api (#20034)
xiaohansong Dec 5, 2022
4f9b660
octavia-cli: Added flag to control whether to reset the streams or no…
marcelopio Dec 5, 2022
3b0512f
JDBC Sources Integration Test migration follow-up: Switch additional …
akashkulk Dec 5, 2022
da0d9a7
Revert "octavia-cli: Added flag to control whether to reset the strea…
terencecho Dec 5, 2022
78aa46d
Add missing "unknown" reason (#20096)
jdpgrailsdev Dec 5, 2022
744e7d5
Add test on `failureOrigin` enum conversion (#20101)
malikdiarra Dec 5, 2022
6b39a1a
Add testid to error view (#20095)
timroes Dec 5, 2022
7810c92
🪟 🎨 Row highlighting for new streams table (#19449)
teallarson Dec 5, 2022
4bef54d
Add README info about using your local CDK locally and in docker (#20…
erohmensing Dec 5, 2022
a1e21c9
octavia-cli: undue skip_reset flag revert and update integration test…
terencecho Dec 5, 2022
94477e4
:window: :wrench: Generify GroupControls to make it more reusable (#2…
lmossman Dec 6, 2022
ea3fb89
Source Postgres: Fix not being able to configure wal2json plugin (unp…
edgao Dec 6, 2022
0e62836
Validate connection id before sync (#20107)
terencecho Dec 6, 2022
5d936cc
Move handling TIMESTAMP_WITH_TIMEZONE to common JdbcSourceOperations …
akashkulk Dec 6, 2022
2b045a9
refresh before syncs when feature flag is on (#19888)
alovew Dec 6, 2022
f1c9d8d
fix type number in schema (#20068)
Dec 6, 2022
4ea4417
warn on navigating away from unsaved connector form with error (#20072)
Dec 6, 2022
413e91b
fixed remarks
andriikorotkov Dec 6, 2022
c7dde44
🪟 🔧 Add comment about feature/experiment usage (#20123)
josephkmh Dec 6, 2022
772a01a
[ISSUE #20086] fix precommit pyproject-flake8 dependency issue (#20087)
maxi297 Dec 6, 2022
9007271
🪟 🐛 Fix tag input styles (#20020)
Dec 6, 2022
d28964c
SAT: Capture configuration updates from connectors' control messages …
alafanechere Dec 6, 2022
22c1e12
Add gradle --scan and :tasks to gradle documentation (#20102)
erohmensing Dec 6, 2022
bedc3b9
airbyte-cdk offset pagination strategy: page_size to be interpolated …
roman-yermilov-gl Dec 6, 2022
39c8801
Extend template for the Java JDBC template by SAT SPEC (#19660)
DoNotPanicUA Dec 6, 2022
e93f8aa
🪟 🎨 Auto-detect schema changes UI fixes (#20070)
edmundito Dec 6, 2022
9ae92e2
Fix additional MySQL integration tests (#20119)
akashkulk Dec 6, 2022
b6a237c
Update mssql.md (#13663)
erica-airbyte Dec 6, 2022
7c03b73
Update Stripe Customer Stream with additional info (#19975)
tybernstein Dec 6, 2022
6065578
edits to managing airbyte cloud doc (#20108)
sophia-wiley Dec 6, 2022
1eac310
🐛 Source Facebook Marketing: update next cursor value at read start (…
artem1205 Dec 6, 2022
23b35ba
airbyte-cdk: bump version (#20143)
roman-yermilov-gl Dec 6, 2022
3e6d5ac
:bug: Source Kafka: fix missing data (#19587)
alexnikitchuk Dec 6, 2022
dfa5ae1
source-java-jdbc: use latest acceptance-test-config.yml format (#20144)
alafanechere Dec 6, 2022
e9b6751
Add dbt cloud integration to default cloud features (#20105)
ambirdsall Dec 6, 2022
b7816f4
🐛 Destination ClickHouse: Update Normalization Docker File (#19573)
genzgd Dec 6, 2022
86f61a5
Revert "RecordSchemaValidator can resolve $ref schemas (#19625)" (#20…
gosusnp Dec 6, 2022
b5fdbaf
🪟 🔧 Add auto-detect schema changes feature flag (#20035)
edmundito Dec 6, 2022
28e2059
MySQL Source : Check for `REQUIRE CLIENT` privilege in CDC (#20000)
akashkulk Dec 6, 2022
779f275
Move CatalogDiff modal from views to components (#20024)
edmundito Dec 6, 2022
92ad0fd
Destination doc and warning updates (#20110)
evantahler Dec 6, 2022
4429968
Show http method in the connector builder test panel request tab (#20…
clnoll Dec 6, 2022
293075e
Postgres source: handle terminate connection exception with test. (#1…
sashaNeshcheret Dec 6, 2022
b5c08ce
Stop sync on a null value in a cursor column (#19889)
rodireich Dec 6, 2022
4697835
`socat` gets more resources (#19953)
evantahler Dec 6, 2022
2568d61
Issue 19733 cdk clarify config error message for config files (#20019)
maxi297 Dec 6, 2022
0164003
Destination Clickhouse: Publish strict encrypt variant (#20171)
edgao Dec 7, 2022
7b0aecb
Source Firebolt: allow reading from views (#16583)
ptiurin Dec 7, 2022
72c0b9b
Use a separate node pool to run custom connector jobs (#19770)
xiaohansong Dec 7, 2022
69a0f24
lint CDK files (#20163)
evantahler Dec 7, 2022
e55757b
[Connector Builder] upgrade orval and use connector manifest schema d…
lmossman Dec 7, 2022
61ddba6
Alex/lowcode custom components docs (#20176)
girarda Dec 7, 2022
0f8c39c
Remove Change Management section as it was outdated. Added Authentica…
bgroff Dec 7, 2022
9cb5714
ci-credentials: update GSM secrets with updated configuration values …
alafanechere Dec 7, 2022
6e155d3
🪟 🎉 Add datepicker for date/date-time fields in connector form (#19678)
josephkmh Dec 7, 2022
08c0ba2
🐛 Source Facebook Marketing: fix fields permission error (#20165)
artem1205 Dec 7, 2022
e12d366
🪟🧹 Improve connector form types (#20057)
Dec 7, 2022
eb67966
fix types (#20187)
Dec 7, 2022
199d246
Added stylelintignore for generated coverage files. (#20097)
krishnaglick Dec 7, 2022
f57fcdf
test/publish commands: always run update secrets (#20183)
alafanechere Dec 7, 2022
8a94f27
🪟 🎉 new streams table edit modal namespace and stream (#19713)
Dec 7, 2022
f328706
Source Bing Ads: add fields to schema (#20005)
LuliRib Dec 7, 2022
3532931
Docs: update list of supported streams in Freshdesk (#20125)
juweins Dec 7, 2022
ab44197
Source Close.com: migration to low-code (#18968)
roman-yermilov-gl Dec 7, 2022
a7c4f1d
regenerated lockfile with resolved & integrity (#20191)
josephkmh Dec 7, 2022
28f1f49
Display Throughput and Progress Bar in Sync UI (#19193)
evantahler Dec 7, 2022
ca67ee7
🪟 🎉 Add auto-detect schema changes option to connection UIs (#19734)
teallarson Dec 7, 2022
078ad42
🪟 🐛 Fix test assertion in datepicker tests (#20188)
josephkmh Dec 7, 2022
37c432f
🪟 🎉 Change default sync mode (#20126)
timroes Dec 7, 2022
1c02097
🪟 🧹 Improve and fix linting in webapp-e2e-tests (#20134)
edmundito Dec 7, 2022
1a0b7df
November release notes docs (#20199)
sophia-wiley Dec 7, 2022
fd8b83d
Add custom connector flag for reset job (#20205)
xiaohansong Dec 7, 2022
3bab0da
CDK: offset_increment.page_size make as [int, InterpolatedString] (#2…
grubberr Dec 7, 2022
d7e11b6
database migration to add column for field selection info (#20202)
mfsiega-airbyte Dec 7, 2022
1581821
Bump Airbyte version from 0.40.23 to 0.40.24 (#20206)
octavia-squidington-iii Dec 7, 2022
9eb0f0d
Enable full SAT for the Snowflake source (#20138)
DoNotPanicUA Dec 8, 2022
36d4c92
Enable full SAT for the BigQuery source (#19720)
DoNotPanicUA Dec 8, 2022
d2ac3ae
added integration type field to the dectination_definition file and a…
andriikorotkov Dec 8, 2022
d55c3f0
Add notification and metrics docs to sidebar (#20210)
arimbr Dec 8, 2022
5658fa9
typo fix (#20207)
sophia-wiley Dec 8, 2022
6db6bf9
Add information about running docs live (#18914)
erohmensing Dec 8, 2022
3877df9
🪟 🎨 New stream details panel (#19219)
dizel852 Dec 8, 2022
50f22cd
[ISSUE #15628] apply lookback window on earliest datetime between sta…
maxi297 Dec 8, 2022
db70435
🪟 🎨 Update toast design (#19980)
dizel852 Dec 8, 2022
9c2a45f
:tada: Source Amplitude: enable data region selection (#19727)
mariamthiam Dec 8, 2022
d64c9b6
Source Gridly: add icon and make `grid_id` parameter required (#20048)
hntan Dec 8, 2022
020b95a
Rm DbMigration Controller (#20213)
benmoriceau Dec 8, 2022
7bfb69c
add storybook for RadioButton component (#20228)
dizel852 Dec 8, 2022
afc8afa
fixed tests
andriikorotkov Dec 8, 2022
aa27ccc
Merge remote-tracking branch 'origin/akorotkov/remove_factory' into a…
andriikorotkov Dec 8, 2022
dd023d0
fixed tests
andriikorotkov Dec 8, 2022
fb53c3a
fixed tests
andriikorotkov Dec 8, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.40.23
current_version = 0.40.24
commit = False
tag = False
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\-[a-z]+)?
Expand Down
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


### SHARED ###
VERSION=0.40.23
VERSION=0.40.24

# When using the airbyte-db via default docker image
CONFIG_ROOT=/data
Expand Down
470 changes: 237 additions & 233 deletions .github/workflows/gradle.yml

Large diffs are not rendered by default.

23 changes: 18 additions & 5 deletions .github/workflows/publish-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,12 @@ jobs:
- name: Write Integration Test Credentials for ${{ matrix.connector }}
run: |
source venv/bin/activate
ci_credentials ${{ matrix.connector }}
ci_credentials ${{ matrix.connector }} write-to-storage
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ matrix.connector }}" ] || [ 'base-normalization' = "${{ matrix.connector }}" ]; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
ci_credentials destination-bigquery write-to-storage
ci_credentials destination-postgres write-to-storage
ci_credentials destination-snowflake write-to-storage
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
Expand Down Expand Up @@ -317,9 +317,22 @@ jobs:
with:
command: |
echo "$SPEC_CACHE_SERVICE_ACCOUNT_KEY" > spec_cache_key_file.json && docker login -u ${DOCKER_HUB_USERNAME} -p ${DOCKER_HUB_PASSWORD}
./tools/integrations/manage.sh publish airbyte-integrations/${{ matrix.connector }} ${{ github.event.inputs.run-tests }} --publish_spec_to_cache
./tools/integrations/manage.sh publish airbyte-integrations/${{ matrix.connector }} ${{ github.event.inputs.run-tests }} --publish_spec_to_cache
attempt_limit: 3
attempt_delay: 5000 in # ms
- name: Update Integration Test Credentials after test run for ${{ github.event.inputs.connector }}
if: always()
run: |
source venv/bin/activate
ci_credentials ${{ matrix.connector }} update-secrets
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ matrix.connector }}" ] || [ 'base-normalization' = "${{ matrix.connector }}" ]; then
ci_credentials destination-bigquery update-secrets
ci_credentials destination-postgres update-secrets
ci_credentials destination-snowflake update-secrets
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
- name: Create Sentry Release
if: startsWith(matrix.connector, 'connectors') && success()
run: |
Expand Down
21 changes: 17 additions & 4 deletions .github/workflows/test-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ jobs:
- name: Write Integration Test Credentials for ${{ github.event.inputs.connector }}
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }}
ci_credentials ${{ github.event.inputs.connector }} write-to-storage
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ] || [ 'base-normalization' = "${{ github.event.inputs.connector }}" ]; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
ci_credentials destination-bigquery write-to-storage
ci_credentials destination-postgres write-to-storage
ci_credentials destination-snowflake write-to-storage
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
Expand All @@ -131,6 +131,19 @@ jobs:
command: ./tools/bin/ci_integration_test.sh ${{ github.event.inputs.connector }}
attempt_limit: 3
attempt_delay: 10000 # in ms
- name: Update Integration Test Credentials after test run for ${{ github.event.inputs.connector }}
if: always()
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }} update-secrets
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ] || [ 'base-normalization' = "${{ github.event.inputs.connector }}" ]; then
ci_credentials destination-bigquery update-secrets
ci_credentials destination-postgres update-secrets
ci_credentials destination-snowflake update-secrets
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
- name: Archive test reports artifacts
if: github.event.inputs.comment-id && failure()
uses: actions/upload-artifact@v3
Expand Down
21 changes: 17 additions & 4 deletions .github/workflows/test-performance-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ jobs:
- name: Write Integration Test Credentials for ${{ github.event.inputs.connector }}
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }}
ci_credentials ${{ github.event.inputs.connector }} write-to-storage
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ] || [ 'base-normalization' = "${{ github.event.inputs.connector }}" ]; then
ci_credentials destination-bigquery
ci_credentials destination-postgres
ci_credentials destination-snowflake
ci_credentials destination-bigquery write-to-storage
ci_credentials destination-postgres write-to-storage
ci_credentials destination-snowflake write-to-storage
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
Expand All @@ -124,6 +124,19 @@ jobs:
ACTION_RUN_ID: ${{github.run_id}}
# Oracle expects this variable to be set. Although usually present, this is not set by default on Github virtual runners.
TZ: UTC
- name: Update Integration Test Credentials after test run for ${{ github.event.inputs.connector }}
if: always()
run: |
source venv/bin/activate
ci_credentials ${{ github.event.inputs.connector }} update-secrets
# normalization also runs destination-specific tests, so fetch their creds also
if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ] || [ 'base-normalization' = "${{ github.event.inputs.connector }}" ]; then
ci_credentials destination-bigquery update-secrets
ci_credentials destination-postgres update-secrets
ci_credentials destination-snowflake update-secrets
fi
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
- name: Archive test reports artifacts
if: github.event.inputs.comment-id && failure()
uses: actions/upload-artifact@v3
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ acceptance_tests_logs/

# Secrets
secrets
updated_configurations
!airbyte-integrations/connector-templates/**/secrets

# Test logs
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ repos:
).?$

- repo: https://github.com/csachs/pyproject-flake8
rev: v0.0.1a2.post1
rev: v6.0.0
hooks:
- id: pyproject-flake8
args: ["--config", "pyproject.toml"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import com.google.common.annotations.VisibleForTesting;
import io.airbyte.api.client.generated.AttemptApi;
import io.airbyte.api.client.generated.ConnectionApi;
import io.airbyte.api.client.generated.DbMigrationApi;
import io.airbyte.api.client.generated.DestinationApi;
import io.airbyte.api.client.generated.DestinationDefinitionApi;
import io.airbyte.api.client.generated.DestinationDefinitionSpecificationApi;
Expand Down Expand Up @@ -58,7 +57,6 @@ public class AirbyteApiClient {
private final SourceDefinitionSpecificationApi sourceDefinitionSpecificationApi;
private final WorkspaceApi workspaceApi;
private final HealthApi healthApi;
private final DbMigrationApi dbMigrationApi;
private final AttemptApi attemptApi;
private final StateApi stateApi;

Expand All @@ -75,7 +73,6 @@ public AirbyteApiClient(final ApiClient apiClient) {
sourceDefinitionSpecificationApi = new SourceDefinitionSpecificationApi(apiClient);
workspaceApi = new WorkspaceApi(apiClient);
healthApi = new HealthApi(apiClient);
dbMigrationApi = new DbMigrationApi(apiClient);
attemptApi = new AttemptApi(apiClient);
stateApi = new StateApi(apiClient);
}
Expand Down Expand Up @@ -128,10 +125,6 @@ public HealthApi getHealthApi() {
return healthApi;
}

public DbMigrationApi getDbMigrationApi() {
return dbMigrationApi;
}

public AttemptApi getAttemptApi() {
return attemptApi;
}
Expand Down
Loading