bug: add workspace_id to query #20011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmossman
reviewed
Dec 2, 2022
| @@ -41,6 +41,12 @@ void setup() { | |||
| null)); | |||
| } | |||
|
|
|||
| @Test | |||
| void testGetWorkspace() throws ConfigNotFoundException, IOException, JsonValidationException { | |||
| configRepository.writeStandardWorkspaceNoSecrets(createBaseStandardWorkspace().withWorkspaceId(UUID.randomUUID())); | |||
There was a problem hiding this comment.
So before your bug fix, would this test fail because the returned workspace would have the UUID.randomUUID() instead of the WORKSPACE_ID? Just making sure I follow the logic of the test
pmossman
approved these changes
Dec 2, 2022
terencecho
added a commit
that referenced
this pull request
Dec 2, 2022
This reverts commit ef13c3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
workspaceQuery()should take in a workspace id in order to service get workspace, but right now it does not.