-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove un-used update/delete custom connector api #20034
Conversation
@marcelopio I know you mentioned working on CLI custom connectors in an issue comment earlier, can you verify that this PR is ok with your changes as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, assuming builds pass!
@pmossman Took another pass and I think it should be straightforward to remove the creation in the same PR - PTAL if you got a chance! And for @marcelopio's PR - I commented in your PR, the update path needs to be changed |
It is ok for me. Actually this solves a doubt I was having if I should use custom or not. Now I just have the question if I should manage connectors version for non custom connectors, but that is to be discussed on my PR. Thanks! |
@xiaohansong looks like there may be some broken tests in the build after removing those endpoints, maybe some tests need to be converted to the |
Just confirming that we are not using any of these endpoints on the frontend anymore 👍 |
What
#19670
https://github.com/airbytehq/airbyte-cloud/issues/3642
remove un-used update/delete custom connector api and create connector api