Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Add comment about feature/experiment usage #20123

Merged
merged 3 commits into from
Dec 6, 2022
Merged

🪟 🔧 Add comment about feature/experiment usage #20123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6462e8a
add comment about feature/experiment usage
josephkmh Dec 6, 2022
e9476f1
Update experiments.ts
josephkmh Dec 6, 2022
e40070e
Update types.tsx
josephkmh Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airbyte-webapp/src/hooks/services/Experiment/experiments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/* eslint sort-keys: "error" */
/**
* Experiments are short-term flags for A/B testing or staged rollouts of features.
*
* When adding a new feature flag in LaunchDarkly to consume in code you'll need to make
* sure to update the typing here.
*/
Expand Down
5 changes: 5 additions & 0 deletions airbyte-webapp/src/hooks/services/Feature/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/**
* FeatureItems are for permanent flags to differentiate features between environments (e.g. Cloud vs. OSS),
* workspaces, specific user groups, etc.
*/

export enum FeatureItem {
AllowUploadCustomImage = "ALLOW_UPLOAD_CUSTOM_IMAGE",
AllowCustomDBT = "ALLOW_CUSTOM_DBT",
Expand Down