-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Source: Commcare #20220
New Source: Commcare #20220
Conversation
@sajarin I can review this PR. |
Hi @siddhant3030, Thanks for your amazing contribution!
Also, can you upload a screenshot of It would be good if you move custom classes to separate file/s. |
@siddhant3030 can you respond to the requested changes ASAP? Thanks! |
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-commcare/source_commcare/source.py
Show resolved
Hide resolved
@geekwhocodes Thank you for the suggestions. I'll work on this. Also we are fixing the acceptance test. As soon as we're done we can let you know. I'll also add the screenshot. |
@siddhant3030 any update here? We're trying to get this merged before the end of the week. Otherwise, the merging might be significantly delayed due to the holidays. We're fairly close to finishing the review here. |
@sajarin will try to push this today |
@geekwhocodes @sajarin can you help me with this? This is the only test case which is failing in acceptance test |
Hello 👋:skin-tone-2: and thank you for your contribution! Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays. If you have any questions or need further clarification, please don't hesitate to ping via Slack. |
@geekwhocodes @sajarin any updates on this? Needed your help the acceptance this. I have posted the query above |
/publish connector=connectors/source-commcare run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Commcare is a digital data collection platform for front-line workers working in offline settings. For organizations using Commcare having a native Airbyte connector to import data will allow for ingestion into their data warehouses and use of the data for analysis. Current processes involve ingestion with Python scripts, maintaining schemas ad-hoc in the scripts, and through Excel downloads.
How
The current version of the connector provides for ingesting data through Airbyte from multiple forms in an organization's Commcare application. A typical use case of a Commcare system involves a root project space in which multiple applications can be hosted and can be defined for multiple program interventions. The current connector defines the ingestion of data at the application level as that is the most common entry point for Commcare Applications. The implemented version of the connector will allow for all sync modes - full refresh and incremental including de-duped mode. A best-guess normalization is also provided to ease the normalization process using a couple of python libraries to guess the schema from the data fetched back through the API.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Integration
Put your integration tests output here.
Acceptance