-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oauth): dont convert config values to string when building consent url #20932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
issues related to the platform
area/server
labels
Dec 30, 2022
pedroslopez
temporarily deployed
to
more-secrets
December 30, 2022 06:10
— with
GitHub Actions
Inactive
pedroslopez
temporarily deployed
to
more-secrets
December 30, 2022 06:11
— with
GitHub Actions
Inactive
pedroslopez
commented
Dec 30, 2022
final String k = entry.getKey(); | ||
final JsonNode v = entry.getValue(); | ||
|
||
// Note: This does not currently handle replacing masked secrets within nested objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this, but it's not an new issue, just commented in case it comes up sometime in the future. I verified with the previous behavior and if there was a nested object in the input configuration, deserializeToStringMap
actually threw an error.
pedroslopez
temporarily deployed
to
more-secrets
December 30, 2022 17:51
— with
GitHub Actions
Inactive
pedroslopez
temporarily deployed
to
more-secrets
December 30, 2022 17:52
— with
GitHub Actions
Inactive
alafanechere
approved these changes
Dec 30, 2022
evantahler
approved these changes
Jan 2, 2023
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes OC issue https://github.com/airbytehq/oncall/issues/1250
If the configuration passed to generate the consent URL includes non-string values, they would be implicitly converted to strings when replacing masked values with secrets.
We noticed this happening specifically for Salesforce when re-authenticating the source, since it uses the
is_sandbox
field, which is a boolean. Issuing theget_consent_url
call for an already created connector would return a 422 status code with the following error:How
The
getOAuthFromDBIfNeeded
method was using a string map and callingJsons.deserializeToStringMap
, which basically converts all values to strings. In order to keep the original types, I reworked the implementation to use JsonNodes directly.