🪟🧹 Connector builder: Fast fields performance improvements #20957

flash1293 · 2023-01-03T09:12:04Z

Fixes #20947

This PR is introducing fast field and memoization in some key places to speed up the perceived performance of the UI.

I left some comments in the code to explain a bit in greater detail what the individual improvements are about. However, these are the ones I added:

Using FastField for oneOf and BuilderField
Get formik to render half as often
Memoize UserInputHelper (change a bit the helper functions for building the inputs list so they don't take the entire state)
Memoize heaviest part of keyvalue list (we can improve this further by using fast field for each individual item, but there's a separate issue for that)
Move stream config controls to a separate component so the whole component is re-rendered less

Measurements below are using a complex form with slicer, paginator and multiple request params, 4x CPU slowdown and heavy instrumentation - production build is much faster:

Before when typing quickly (with the other performance PR merged already):
There are two commits per keystroke, and both take 60ms - this causes heavy frame dropping

Now:
One commit per keystroke, roughly 16ms - very little frame dropping

While I'm not super happy with this solution, I think it's good enough for the moment until we can switch away from formik which will re-render much less with idiomatic usage.

…nector-form-types

…or-form-loading-state

…or-form-name-override

…connector-form-unifinished-flows

…ector-form-remove-ui-widget-state

….module.scss Co-authored-by: Tim Roes <[email protected]>

…or-form-loading-state

…irbytehq/airbyte into flash1293/connector-form-loading-state

…connector-form-name-override

…connector-form-unifinished-flows

…or-form-loading-state

…connector-form-name-override

…connector-form-unifinished-flows

…or-form-loading-state

…connector-form-name-override

…connector-form-unifinished-flows

…-form-loading-state

flash1293 · 2023-01-06T10:31:48Z

airbyte-webapp/src/components/connectorBuilder/Builder/StreamConfigView.tsx

+  selectedTab: "configuration" | "schema";
+}) => {
+  const { formatMessage } = useIntl();
+  const [field, , helpers] = useField<BuilderStream[]>("streams");


Splitting out the controls to isolate the re-render to this component instead of re-rendering the full stream config view.

flash1293 · 2023-01-06T10:35:08Z

airbyte-webapp/src/components/connectorBuilder/Builder/KeyValueListField.tsx

@@ -60,29 +61,53 @@ interface KeyValueListFieldProps {
 export const KeyValueListField: React.FC<KeyValueListFieldProps> = ({ path, label, tooltip }) => {
  const [{ value: keyValueList }, , { setValue: setKeyValueList }] = useField<Array<[string, string]>>(path);


Can't get rid of the "useField" here, but we can memoize everything happening within the component if the key value list didn't actually change

Why can't we use a FastField here?

flash1293 · 2023-01-06T10:37:04Z

airbyte-webapp/src/components/connectorBuilder/Builder/BuilderFieldWithInputs.tsx

  const { formatMessage } = useIntl();
-  const [modalOpen, setModalOpen] = useState(false);
  const { builderFormValues } = useConnectorBuilderFormState();


We can't get rid of subscribing to the builder form state, but we can memoize building the actual options list and memoize the actual listbox component based on that.

flash1293 · 2023-01-06T11:19:04Z

airbyte-webapp/src/pages/ConnectorBuilderPage/ConnectorBuilderPage.tsx

-        )}
+      <Formik
+        initialValues={initialFormValues.current}
+        validateOnBlur={false}


Noticed that formik would still re-trigger renders if all validateOn* are explicitly disabled - this is a big saving.

flash1293 · 2023-01-06T11:19:35Z

airbyte-webapp/src/components/connectorBuilder/Builder/BuilderOneOf.tsx

+export const BuilderOneOf: React.FC<BuilderOneOfProps> = (props) => {
+  return (
+    <FastField name={`${props.path}.type`}>
+      {(fastFieldProps: FastFieldProps<string>) => <InnerBuilderOneOf {...props} {...fastFieldProps} />}


Wrap the oneOf block in its own fastfield

My understanding here is that it is okay to have the name of this FastField be props.path.type because the logic in this class only needs to run when type of the oneOf changes. Anything else changing inside the oneOf will be handled by the FastFields in the children.

Is this correct?

flash1293 · 2023-01-06T11:20:05Z

airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx

+export const BuilderField: React.FC<BuilderFieldProps> = (props) => {
+  return (
+    <FastField name={props.path}>
+      {({ field, form, meta }: FastFieldProps<unknown>) => (


Wrap each builder field in a fast field instead of using useField

lmossman

@flash1293 I pushed one change here and left a few other comments as well. I'm going to merge this as is once the build is green in order to unblock the release, so if there are any other follow-up changes you want to make based on the comments I left then we can just do that in a follow-up PR.

After pushing my fix, it seems to be working as expected from my local testing, and it seems to be nice and snappy. Nice work!

lmossman · 2023-01-06T18:14:08Z

airbyte-webapp/src/components/connectorBuilder/Builder/BuilderOneOf.tsx

+export const BuilderOneOf: React.FC<BuilderOneOfProps> = (props) => {
+  return (
+    <FastField name={`${props.path}.type`}>
+      {(fastFieldProps: FastFieldProps<string>) => <InnerBuilderOneOf {...props} {...fastFieldProps} />}


My understanding here is that it is okay to have the name of this FastField be props.path.type because the logic in this class only needs to run when type of the oneOf changes. Anything else changing inside the oneOf will be handled by the FastFields in the children.

Is this correct?

lmossman · 2023-01-06T18:18:17Z

airbyte-webapp/src/components/connectorBuilder/Builder/KeyValueListField.tsx

@@ -60,29 +61,53 @@ interface KeyValueListFieldProps {
 export const KeyValueListField: React.FC<KeyValueListFieldProps> = ({ path, label, tooltip }) => {
  const [{ value: keyValueList }, , { setValue: setKeyValueList }] = useField<Array<[string, string]>>(path);


Why can't we use a FastField here?

lmossman · 2023-01-06T18:19:09Z

airbyte-webapp/src/components/connectorBuilder/Builder/BuilderSidebar.tsx

@@ -111,7 +111,9 @@ export const BuilderSidebar: React.FC<BuilderSidebarProps> = React.memo(({ class
        <FontAwesomeIcon icon={faUser} />
        <FormattedMessage
          id="connectorBuilder.userInputs"
-          values={{ number: values.inputs.length + getInferredInputs(values).length }}
+          values={{
+            number: values.inputs.length + getInferredInputs(values.global, values.inferredInputOverrides).length,


Any reason the getInferredInputs result is not being memoized in this component?

lmossman · 2023-01-06T18:24:45Z

airbyte-webapp/src/components/connectorBuilder/types.ts

@@ -115,8 +115,8 @@ export const DEFAULT_BUILDER_STREAM_VALUES: Omit<BuilderStream, "id"> = {
  },
 };

-function getInferredInputList(values: BuilderFormValues): BuilderFormInput[] {
-  if (values.global.authenticator.type === "ApiKeyAuthenticator") {
+function getInferredInputList(global: BuilderFormValues["global"]): BuilderFormInput[] {


Is there a reason you chose to have this taken in the entire global object instead of just the global.authenticator, or even global.authenticator.type? Since it seems like that is the only value from global that is used in this function

lmossman · 2023-01-06T19:00:59Z

airbyte-webapp/src/services/connectorBuilder/ConnectorBuilderStateService.tsx

@@ -119,9 +120,9 @@ export const ConnectorBuilderFormStateProvider: React.FC<React.PropsWithChildren
      editorView !== "ui"
        ? jsonManifest
        : builderFormValues === lastValidBuilderFormValues
-        ? jsonManifest
+        ? derivedJsonManifest


FYI I pushed this change because I noticed when testing this branch that the stream URL in the testing panel was not being updated when I would change the URL path of the stream.

After some digging, I figured out that this should be using the derivedJsonManifest in this case, because jsonManifest just contains the local storage JSON value of the yaml editor, which means it contained outdated info.

The only reason this was working on master is because we were doing the merge() call above (which was removed in this PR), which caused builderFormValues === lastValidBuilderFormValues to always evaluate to false. Now that the merge is removed, that evaluates to true when there are no errors, so it was returning the jsonManifest value which was outdated, resulting in weird behavior.

* improve some types * improve further * clean up a bit more * refactor loading state * move loading state up * remove isLoading references * remove unused props and make fetch connector error work * remove special component for name * remove top level state for unifinished flows * start removing uiwidget * Update airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.module.scss Co-authored-by: Tim Roes <[email protected]> * remove undefined option for selected id * remove unused prop * fix types * remove uiwidget state * clean up * adjust comment * handle errors in a nice way * do not respect default on oneOf fields * rename to formblock * reduce re-renders * pass error to secure inputs * simplify and improve styling * align top * code review * remove comment * review comments * rename file * be strict about boolean values * add example * track form error in error boundary * review comments * handle unexpected cases better * speed up some bits * more changes * enrich error with connector id * 🪟🎉 Add copy stream button (#20577) * add copy stream button * review comments * rename prop * 🪟🎉 Connector builder: Integrate connector form for test input (#20385) * move connector builder components into the same shared components/connectorBuilder directory * move diff over from poc branch * save current progress * add modal for adding streams * focus stream after adding and reset button style * add reset confirm modal and select view on add * style global config and streams buttons * styling improvements * handle long stream names better * pull in connector manifest schema directly * add box shadows to resizable panels * upgrade orval and use connector manifest schema directly * remove airbyte protocol from connector builder api spec * generate python models from openapi change * fix position of yaml toggle * handle no stream case with better looking message * group global fields into single object and fix console error * confirmation modal on toggling dirty form + cleanup * fix connector name display * undo change to manifest schema * remove commented code * remove unnecessary change * fix spacing * use shadow mixin for connector img * add comment about connector img * change onSubmit to no-op * remove console log * clean up styling * simplify sidebar to remove StreamSelectButton component * swap colors of toggle * move FormikPatch to src/core/form * move types up to connectorBuilder/ level * use grid display for ui yaml toggle button * use spread instead of setting array index directly * add intl in missing places * pull connector manifest schema in through separate openapi spec * use correct intl string id * throttle setting json manifest in yaml editor * use button prop instead of manually styling * consolidate AddStreamButton styles * fix sidebar flex styles * use specific flex properties instead of flex * clean up download and reset button styles * use row-reverse for yaml editor download button * fix stream selector styles to remove margins * give connector setup guide panel same corner and shadow styles * remove blur from page display * set view to stream when selected in test panel * add placeholder when stream name is empty * switch to index-based stream selection to preserve testing panel selected stream on rename * handle empty name in stream selector * make connector form work in connector builder * fix small stuff * add warning label * review comments * adjust translation Co-authored-by: lmossman <[email protected]> * use request_body_json instead of request_body_data * 🪟 🎨 Move `Add` button into the line of Connector Builder key value list fields (#20699) * move add button into line * add stories for empty with control, and content + control * change button name to Control * 🪟🎉 Connector builder: Allow defining inputs (#20431) * move connector builder components into the same shared components/connectorBuilder directory * move diff over from poc branch * save current progress * add modal for adding streams * focus stream after adding and reset button style * add reset confirm modal and select view on add * style global config and streams buttons * styling improvements * handle long stream names better * pull in connector manifest schema directly * add box shadows to resizable panels * upgrade orval and use connector manifest schema directly * remove airbyte protocol from connector builder api spec * generate python models from openapi change * fix position of yaml toggle * handle no stream case with better looking message * group global fields into single object and fix console error * confirmation modal on toggling dirty form + cleanup * fix connector name display * undo change to manifest schema * remove commented code * remove unnecessary change * fix spacing * use shadow mixin for connector img * add comment about connector img * change onSubmit to no-op * remove console log * clean up styling * simplify sidebar to remove StreamSelectButton component * swap colors of toggle * move FormikPatch to src/core/form * move types up to connectorBuilder/ level * use grid display for ui yaml toggle button * use spread instead of setting array index directly * add intl in missing places * pull connector manifest schema in through separate openapi spec * use correct intl string id * throttle setting json manifest in yaml editor * use button prop instead of manually styling * consolidate AddStreamButton styles * fix sidebar flex styles * use specific flex properties instead of flex * clean up download and reset button styles * use row-reverse for yaml editor download button * fix stream selector styles to remove margins * give connector setup guide panel same corner and shadow styles * remove blur from page display * set view to stream when selected in test panel * add placeholder when stream name is empty * switch to index-based stream selection to preserve testing panel selected stream on rename * handle empty name in stream selector * make connector form work in connector builder * wip * fix small stuff * add basic input UI * user inputs * make most of inputs configuration work * fix a bunch of stuff * handle unknown config types * add warning label * fix label * fix some styling * review comments * improve state management and error handling * handle stored form values that don't contain new fields properly * Update airbyte-webapp/src/locales/en.json Co-authored-by: Lake Mossman <[email protected]> * Update airbyte-webapp/src/components/connectorBuilder/Builder/InputsView.tsx Co-authored-by: Lake Mossman <[email protected]> * inputs editing weirdness * input form reset * using the Label component * 🪟🎉 Connector builder authentication (#20645) * allow auth configuration * check for conflicts with the inferred inputs * fix invisible inputs * reduce redundancy and hide advanced input options for inferred inputs * unnecessary validation * typo * unnecessary effect hook * build spec even for invalid forms but do not update stream list * fix keys * 🪟🎉 Connector builder: Session token and oauth authentication (#20712) * session token and oauth authentication * fill in session token variable * typos * make sure validation error does not go away * 🪟🎉 Connector builder: Always validate inputs form (#20664) * validate user input outside of form * review comments Co-authored-by: lmossman <[email protected]> Co-authored-by: lmossman <[email protected]> * fix merge conflict with dropdown prop being renamed to control * [Connector Builder] Add paginator (#20698) * move connector builder components into the same shared components/connectorBuilder directory * move diff over from poc branch * save current progress * add modal for adding streams * focus stream after adding and reset button style * add reset confirm modal and select view on add * style global config and streams buttons * styling improvements * handle long stream names better * pull in connector manifest schema directly * add box shadows to resizable panels * upgrade orval and use connector manifest schema directly * remove airbyte protocol from connector builder api spec * generate python models from openapi change * fix position of yaml toggle * handle no stream case with better looking message * group global fields into single object and fix console error * confirmation modal on toggling dirty form + cleanup * fix connector name display * undo change to manifest schema * remove commented code * remove unnecessary change * fix spacing * use shadow mixin for connector img * add comment about connector img * change onSubmit to no-op * remove console log * clean up styling * simplify sidebar to remove StreamSelectButton component * swap colors of toggle * move FormikPatch to src/core/form * move types up to connectorBuilder/ level * use grid display for ui yaml toggle button * use spread instead of setting array index directly * add intl in missing places * pull connector manifest schema in through separate openapi spec * use correct intl string id * throttle setting json manifest in yaml editor * use button prop instead of manually styling * consolidate AddStreamButton styles * fix sidebar flex styles * use specific flex properties instead of flex * clean up download and reset button styles * use row-reverse for yaml editor download button * fix stream selector styles to remove margins * give connector setup guide panel same corner and shadow styles * remove blur from page display * set view to stream when selected in test panel * add placeholder when stream name is empty * switch to index-based stream selection to preserve testing panel selected stream on rename * handle empty name in stream selector * make connector form work in connector builder * wip * fix small stuff * add basic input UI * user inputs * make most of inputs configuration work * fix a bunch of stuff * handle unknown config types * add warning label * fix label * fix some styling * review comments * improve state management and error handling * allow auth configuration * check for conflicts with the inferred inputs * fix invisible inputs * handle stored form values that don't contain new fields properly * session token and oauth authentication * fill in session token variable * fix merge of default values * add primaryKey and cursorField to builder types, and consolidate default valeues to types.ts * add cursor and primary key fields to ui * save * add page size and token option inputs * fixes after rebase * add pagination * fix pagination types * handle empty field_name better * Update airbyte-webapp/src/locales/en.json Co-authored-by: Lake Mossman <[email protected]> * Update airbyte-webapp/src/components/connectorBuilder/Builder/InputsView.tsx Co-authored-by: Lake Mossman <[email protected]> * inputs editing weirdness * input form reset * using the Label component * reduce redundancy and hide advanced input options for inferred inputs * unnecessary validation * typo * unnecessary effect hook * build spec even for invalid forms but do not update stream list * typos * make sure validation error does not go away * make primary key and cursor optional, and reorder * save toggle group progress * fix style of toggle label * handle empty values better * fix page size/token option field validation and rendering * handle cursor pagination page size option correctly Co-authored-by: Joe Reuter <[email protected]> * [Connector Builder] Add stream slicer (#20748) * move connector builder components into the same shared components/connectorBuilder directory * move diff over from poc branch * save current progress * add modal for adding streams * focus stream after adding and reset button style * add reset confirm modal and select view on add * style global config and streams buttons * styling improvements * handle long stream names better * pull in connector manifest schema directly * add box shadows to resizable panels * upgrade orval and use connector manifest schema directly * remove airbyte protocol from connector builder api spec * generate python models from openapi change * fix position of yaml toggle * handle no stream case with better looking message * group global fields into single object and fix console error * confirmation modal on toggling dirty form + cleanup * fix connector name display * undo change to manifest schema * remove commented code * remove unnecessary change * fix spacing * use shadow mixin for connector img * add comment about connector img * change onSubmit to no-op * remove console log * clean up styling * simplify sidebar to remove StreamSelectButton component * swap colors of toggle * move FormikPatch to src/core/form * move types up to connectorBuilder/ level * use grid display for ui yaml toggle button * use spread instead of setting array index directly * add intl in missing places * pull connector manifest schema in through separate openapi spec * use correct intl string id * throttle setting json manifest in yaml editor * use button prop instead of manually styling * consolidate AddStreamButton styles * fix sidebar flex styles * use specific flex properties instead of flex * clean up download and reset button styles * use row-reverse for yaml editor download button * fix stream selector styles to remove margins * give connector setup guide panel same corner and shadow styles * remove blur from page display * set view to stream when selected in test panel * add placeholder when stream name is empty * switch to index-based stream selection to preserve testing panel selected stream on rename * handle empty name in stream selector * make connector form work in connector builder * wip * fix small stuff * add basic input UI * user inputs * make most of inputs configuration work * fix a bunch of stuff * handle unknown config types * add warning label * fix label * fix some styling * review comments * improve state management and error handling * allow auth configuration * check for conflicts with the inferred inputs * fix invisible inputs * handle stored form values that don't contain new fields properly * session token and oauth authentication * fill in session token variable * fix merge of default values * add primaryKey and cursorField to builder types, and consolidate default valeues to types.ts * add cursor and primary key fields to ui * save * add page size and token option inputs * fixes after rebase * add pagination * fix pagination types * handle empty field_name better * Update airbyte-webapp/src/locales/en.json Co-authored-by: Lake Mossman <[email protected]> * Update airbyte-webapp/src/components/connectorBuilder/Builder/InputsView.tsx Co-authored-by: Lake Mossman <[email protected]> * inputs editing weirdness * input form reset * using the Label component * reduce redundancy and hide advanced input options for inferred inputs * unnecessary validation * typo * unnecessary effect hook * build spec even for invalid forms but do not update stream list * typos * make sure validation error does not go away * make primary key and cursor optional, and reorder * save toggle group progress * fix style of toggle label * handle empty values better * fix page size/token option field validation and rendering * handle cursor pagination page size option correctly * save stream slicer progress * finish stream slicer * fix stream slicer fields and validation Co-authored-by: Joe Reuter <[email protected]> * debounce form builder values update to reduce load * 🪟🔧 Connector builder: use new lowcode manifest (#20715) * use new manifest yaml * Update airbyte-webapp/src/components/connectorBuilder/types.ts Co-authored-by: Lake Mossman <[email protected]> * use updated manifest types Co-authored-by: Lake Mossman <[email protected]> * debounce validation as well * akways show stream test button in error state if there are errors * fix type of oauth input * review comments * fix more * start implementing fast fields * a few more fastfields * fix some stuff * complete fast fields work * memoize a bit more * remove irrelevant change * fix types * some more improvements * prevent all out-of-line validation calls * use derivedJsonManifest when in UI view Co-authored-by: Tim Roes <[email protected]> Co-authored-by: lmossman <[email protected]>

Joe Reuter and others added 30 commits December 5, 2022 11:06

improve some types

d2ed762

Merge remote-tracking branch 'upstream/master' into chore-improve-con…

f474a1c

…nector-form-types

improve further

5b0521f

Merge remote-tracking branch 'upstream/master' into chore-improve-con…

af659fd

…nector-form-types

clean up a bit more

1cd3bbb

refactor loading state

807c436

Merge remote-tracking branch 'upstream/master' into flash1293/connect…

6c76e0f

…or-form-loading-state

move loading state up

05c3107

remove isLoading references

eee4303

remove unused props and make fetch connector error work

7d6f977

remove special component for name

0fe11f0

remove top level state for unifinished flows

34d4814

Merge remote-tracking branch 'upstream/master' into flash1293/connect…

67d62c5

…or-form-name-override

Merge branch 'flash1293/connector-form-name-override' into flash1293/…

afea882

…connector-form-unifinished-flows

Merge branch 'master' into flash1293/connector-form-loading-state

c7e7475

Merge branch 'chore-improve-connector-form-types' into flash1293/conn…

cc7f65f

…ector-form-remove-ui-widget-state

start removing uiwidget

a1c6cbd

Update airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard…

9be8337

….module.scss Co-authored-by: Tim Roes <[email protected]>

Merge remote-tracking branch 'upstream/master' into flash1293/connect…

37cee8f

…or-form-loading-state

Merge branch 'flash1293/connector-form-loading-state' of github.com:a…

5686241

…irbytehq/airbyte into flash1293/connector-form-loading-state

remove undefined option for selected id

7b73364

Merge branch 'flash1293/connector-form-loading-state' into flash1293/…

7058d26

…connector-form-name-override

Merge branch 'flash1293/connector-form-name-override' into flash1293/…

dd7e82a

…connector-form-unifinished-flows

Merge remote-tracking branch 'upstream/master' into flash1293/connect…

6d4c7d3

…or-form-loading-state

Merge branch 'flash1293/connector-form-loading-state' into flash1293/…

d624792

…connector-form-name-override

Merge branch 'flash1293/connector-form-name-override' into flash1293/…

36cf941

…connector-form-unifinished-flows

Merge remote-tracking branch 'upstream/master' into flash1293/connect…

b7a6322

…or-form-loading-state

Merge branch 'flash1293/connector-form-loading-state' into flash1293/…

72b602a

…connector-form-name-override

Merge branch 'flash1293/connector-form-name-override' into flash1293/…

5e47a4a

…connector-form-unifinished-flows

Merge remote-tracking branch 'origin/master' into flash1293/connector…

6c71028

…-form-loading-state

flash1293 commented Jan 6, 2023

View reviewed changes

memoize a bit more

742538e

flash1293 commented Jan 6, 2023

View reviewed changes

remove irrelevant change

b2b03bf

flash1293 commented Jan 6, 2023

View reviewed changes

Joe Reuter added 3 commits January 6, 2023 11:51

fix types

4ce7811

some more improvements

0d5fcc5

prevent all out-of-line validation calls

98a33cf

flash1293 commented Jan 6, 2023

View reviewed changes

flash1293 added ui/connector-builder and removed area/platform issues related to the platform labels Jan 6, 2023

flash1293 changed the title ~~WIP: Connector builder: Fast fields performance improvements~~ 🪟🧹 Connector builder: Fast fields performance improvements Jan 6, 2023

Merge branch 'master' into flash1293/fast-fields

7e08ea7

octavia-squidington-iv added the area/platform issues related to the platform label Jan 6, 2023

Joe Reuter added 2 commits January 6, 2023 16:17

Merge branch 'master' into flash1293/fast-fields

80ec5c6

Merge branch 'master' into flash1293/fast-fields

8c33c36

lmossman self-requested a review January 6, 2023 18:26

lmossman marked this pull request as ready for review January 6, 2023 18:26

lmossman requested a review from a team as a code owner January 6, 2023 18:26

use derivedJsonManifest when in UI view

f996b6d

lmossman approved these changes Jan 6, 2023

View reviewed changes

lmossman enabled auto-merge (squash) January 6, 2023 19:07

lmossman merged commit a50e34b into master Jan 6, 2023

lmossman deleted the flash1293/fast-fields branch January 6, 2023 19:35

octavia-squidington-iii mentioned this pull request Jan 6, 2023

Bump Airbyte version from 0.40.26 to 0.40.27 #21130

Closed

github-actions bot mentioned this pull request Jan 6, 2023

Bump helm chart version reference to 0.43.16 #21134

Closed

octavia-squidington-iii mentioned this pull request Jan 6, 2023

Bump Airbyte version from 0.40.26 to 0.40.27 #21135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🪟🧹 Connector builder: Fast fields performance improvements #20957

🪟🧹 Connector builder: Fast fields performance improvements #20957

flash1293 commented Jan 3, 2023 •

edited

Loading

flash1293 Jan 6, 2023

flash1293 Jan 6, 2023

lmossman Jan 6, 2023

flash1293 Jan 6, 2023

flash1293 Jan 6, 2023

flash1293 Jan 6, 2023

lmossman Jan 6, 2023

flash1293 Jan 6, 2023

lmossman left a comment

lmossman Jan 6, 2023

lmossman Jan 6, 2023

lmossman Jan 6, 2023

lmossman Jan 6, 2023

lmossman Jan 6, 2023

		@@ -60,29 +61,53 @@ interface KeyValueListFieldProps {
		export const KeyValueListField: React.FC<KeyValueListFieldProps> = ({ path, label, tooltip }) => {
		const [{ value: keyValueList }, , { setValue: setKeyValueList }] = useField<Array<[string, string]>>(path);

🪟🧹 Connector builder: Fast fields performance improvements #20957

🪟🧹 Connector builder: Fast fields performance improvements #20957

Conversation

flash1293 commented Jan 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmossman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 commented Jan 3, 2023 •

edited

Loading