Add connection list filtering to the frontend based on a set of sources or destinations #21119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
Base automatically changed from
gosusnp/21024-extend-connection-list-filtering
to
master
January 9, 2023 21:42
…destination-list-pages
…destination-list-pages
…destination-list-pages
…ion-list-filtering-on-source-or-destination-list-pages
teallarson
approved these changes
Jan 18, 2023
| const connectionsWithDestination = connections.filter( | ||
| ({ destination: { destinationId } }) => destinationId === destination.destinationId | ||
| ); | ||
| const { connections: connectionsWithDestination } = useConnectionList({ destinationId: [destination.destinationId] }); |
There was a problem hiding this comment.
Weird to me that these are prop-drilled in for the Source Settings.
Should probably choose one pattern or the other, but that's outside this PR :)
krishnaglick
deleted the
kc/connection-list-filtering-on-source-or-destination-list-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements the connections list filtering for a set of sources or destinations.
Resolves #21162
How
Where appropriate, passes in a set of destination or source id's to the connection list call.