🎉 Typeform - beta certification #21145

midavadim · 2023-01-07T21:20:57Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2023-01-07T21:21:02Z

All committers have signed the CLA.

midavadim · 2023-01-07T21:24:47Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3863983841
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3863983841
🐛 https://gradle.com/s/gk3sgyvixxpjg

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/test_incremental.py::test_incremental_sync - KeyErro...
	 �[31m=================== �[31m�[1m1 failed�[0m, �[32m1 passed�[0m, �[33m32 warnings�[0m�[31m in 1.88s�[0m�[31m ===================�[0m

midavadim · 2023-01-10T19:44:24Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3886709882
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3886709882
🐛 https://gradle.com/s/g3gocesoawfew

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/test_incremental.py::test_incremental_sync - KeyErro...
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m1 passed�[0m, �[33m32 warnings�[0m�[31m in 12.38s�[0m�[31m ===================�[0m

davydov-d · 2023-01-11T08:22:15Z

airbyte-integrations/connectors/source-typeform/acceptance-test-config.yml

@@ -15,12 +15,10 @@ tests:
      empty_streams: ["webhooks"]
      expect_records:
        path: "integration_tests/expected_records.jsonl"
-  # Although incremental tests pass, they don't actually test anything because SATs currently
-  # do not support nested dynamic state. That's why incremental read is tested with a dedicated integration test.


I believe that dedicated test should be deleted as well

midavadim · 2023-01-11T18:42:38Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3895715840
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3895715840
🐛 https://gradle.com/s/mipicvnfofohu

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/test_incremental.py::test_incremental_sync - KeyErro...
	 �[31m=================== �[31m�[1m1 failed�[0m, �[32m1 passed�[0m, �[33m32 warnings�[0m�[31m in 1.96s�[0m�[31m ===================�[0m

midavadim · 2023-01-11T20:10:41Z

/test connector=connectors/source-typeform

midavadim · 2023-01-11T21:10:14Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3896728386
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3896728386
🐛 https://gradle.com/s/oum2sadtuny22

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 ERROR integration_tests/test_incremental.py
	 !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
	 �[31m=============================== �[31m�[1m1 error�[0m�[31m in 0.45s�[0m�[31m ===============================�[0m

midavadim · 2023-01-12T11:07:25Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3901650754
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/3901650754
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_typeform/__init__.py       2      0   100%
source_typeform/source.py       143     34    76%
-------------------------------------------------
TOTAL                           145     34    77%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_typeform/__init__.py       2      0   100%
source_typeform/source.py       143      7    95%
-------------------------------------------------
TOTAL                           145      7    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================= 30 passed, 1 skipped, 31 warnings in 37.21s ==================

midavadim · 2023-01-13T13:22:15Z

/publish connector=connectors/source-typeform

🕑 Publishing the following connectors:
connectors/source-typeform
https://github.com/airbytehq/airbyte/actions/runs/3911685869

Connector	Did it publish?	Were definitions generated?
connectors/source-typeform	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…nto midavadim/13877-typeform-beta

* fixed SAT, fix specs, updated docs * fix incremental * fix incremental * fix incremental * updated connector version in source_definitions.yaml * updated version in source_specs.yaml

fixed SAT, fix specs, updated docs

b9cf317

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform labels Jan 7, 2023

midavadim requested a review from bazarnov January 10, 2023 19:35

bazarnov approved these changes Jan 10, 2023

View reviewed changes

davydov-d approved these changes Jan 11, 2023

View reviewed changes

midavadim added 2 commits January 11, 2023 22:03

fix incremental

82575ee

fix incremental

b6d9d78

fix incremental

e135247

updated connector version in source_definitions.yaml

7407c8f

midavadim temporarily deployed to more-secrets January 13, 2023 13:21 — with GitHub Actions Inactive

Merge branch 'master' into midavadim/13877-typeform-beta

e23cd69

midavadim temporarily deployed to more-secrets January 13, 2023 13:26 — with GitHub Actions Inactive

midavadim added 2 commits January 13, 2023 15:27

Merge branch 'master' into midavadim/13877-typeform-beta

b3cff1e

Merge remote-tracking branch 'origin/midavadim/13877-typeform-beta' i…

0d95fb5

…nto midavadim/13877-typeform-beta

midavadim temporarily deployed to more-secrets January 13, 2023 13:30 — with GitHub Actions Inactive

Merge branch 'master' into midavadim/13877-typeform-beta

6e12a33

midavadim temporarily deployed to more-secrets January 13, 2023 14:33 — with GitHub Actions Inactive

midavadim added 2 commits January 13, 2023 16:34

updated version in source_specs.yaml

6c14497

Merge remote-tracking branch 'origin/midavadim/13877-typeform-beta' i…

5497ea1

…nto midavadim/13877-typeform-beta

midavadim temporarily deployed to more-secrets January 13, 2023 14:37 — with GitHub Actions Inactive

midavadim merged commit 1b185db into master Jan 13, 2023

midavadim deleted the midavadim/13877-typeform-beta branch January 13, 2023 14:37

midavadim temporarily deployed to more-secrets January 13, 2023 14:37 — with GitHub Actions Inactive

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Typeform - beta certification #21145

🎉 Typeform - beta certification #21145

midavadim commented Jan 7, 2023

CLAassistant commented Jan 7, 2023 •

edited

Loading

midavadim commented Jan 7, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 10, 2023 •

edited by github-actions bot

Loading

davydov-d Jan 11, 2023

midavadim commented Jan 11, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 11, 2023

midavadim commented Jan 11, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 12, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading

🎉 Typeform - beta certification #21145

🎉 Typeform - beta certification #21145

Conversation

midavadim commented Jan 7, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Jan 7, 2023 • edited Loading

midavadim commented Jan 7, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 10, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d Jan 11, 2023

Choose a reason for hiding this comment

midavadim commented Jan 11, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 11, 2023

midavadim commented Jan 11, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

midavadim commented Jan 13, 2023 • edited by github-actions bot Loading

CLAassistant commented Jan 7, 2023 •

edited

Loading

midavadim commented Jan 7, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 11, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 11, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 12, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 13, 2023 •

edited by github-actions bot

Loading