Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #19981] adding notifications to 'Publish CDK Manually' #21157

Merged
merged 10 commits into from
Jan 17, 2023
Merged

[ISSUE #19981] adding notifications to 'Publish CDK Manually' #21157

merged 10 commits into from
Jan 17, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Jan 9, 2023

What

Adding notifications on release

@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:10 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:10 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:14 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 9, 2023 15:14 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:33 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:35 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 10, 2023 15:35 — with GitHub Actions Inactive
Base automatically changed from issue-19981_avoid-race-condition-on-airbyte-cdk-release to master January 11, 2023 13:28
@maxi297 maxi297 requested a review from a team as a code owner January 11, 2023 13:28
@maxi297 maxi297 force-pushed the issue-19981_notifications-on-publish-cdk-manually branch from 55bccda to 3fe51b9 Compare January 11, 2023 14:27
@maxi297 maxi297 temporarily deployed to more-secrets January 11, 2023 14:29 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 11, 2023 14:30 — with GitHub Actions Inactive
@clnoll
Copy link
Contributor

clnoll commented Jan 11, 2023

@maxi297 do you have screenshots of the notifications that you could add to the PR description?

@maxi297
Copy link
Contributor Author

maxi297 commented Jan 11, 2023

@maxi297 do you have screenshots of the notifications that you could add to the PR description?

@clnoll I did a test on #issue-19981_test-release-notification that looks like this:
image

clnoll
clnoll requested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 q for you @maxi297.

.github/workflows/publish-cdk-command-manually.yml Outdated Show resolved Hide resolved
@maxi297 maxi297 temporarily deployed to more-secrets January 13, 2023 19:24 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 13, 2023 19:24 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 13, 2023 19:24 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 13, 2023 19:24 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 16, 2023 13:55 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 16, 2023 13:55 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 16, 2023 13:56 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 16, 2023 13:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

clnoll
clnoll approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 13:26 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 13:26 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 13:27 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 13:27 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 14:28 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 14:29 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 15:29 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 15:30 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 16:10 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 16:10 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 17:28 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 17:28 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 18:12 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 18:13 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 18:50 — with GitHub Actions Inactive
@maxi297 maxi297 temporarily deployed to more-secrets January 17, 2023 18:50 — with GitHub Actions Inactive
@maxi297 maxi297 merged commit 2c3be39 into master Jan 17, 2023
@maxi297 maxi297 deleted the issue-19981_notifications-on-publish-cdk-manually branch January 17, 2023 21:05
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai left review comments

@clnoll clnoll clnoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxi297 @clnoll @brianjlai