Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess get DestinationDefinition calls #21207

Merged

Conversation

krishnaglick
Copy link
Contributor

What

The destination definition was already available from the connection form service, no need to make the call again on the transformation view.

How

The destination definition is now pulled out of the connection form service, instead of being loaded again.

…form service, no need to make the call again.
…unnecessary-extra-destination-definition-call
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test.

@krishnaglick krishnaglick enabled auto-merge (squash) January 18, 2023 18:39
@krishnaglick krishnaglick merged commit 747d15f into master Jan 18, 2023
@krishnaglick krishnaglick deleted the kc/remove-unnecessary-extra-destination-definition-call branch January 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants