Normalization & Transformation do not have a loading state #21232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added await property to be sure that Formik will handle "isSubmitting" state in a proper way
dizel852
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Code LGTM 👍
Also tested locally - works as should
Passing to @edmundito for another review
edmundito
requested review from
krishnaglick
and removed request for
edmundito
|
I thought this would need a |
matter-q
deleted the
mark/normalization-&-Transformation-do-not-have-a-loading-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #17692
How
Added "await" property to be sure that Formik will handle "isSubmitting" state in a proper way
Note: I used a slow connection (Slow 3G) in the Network property to see the loading state
Loom
https://www.loom.com/share/2cdbe527118a4033b73e610e7c84164d