Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source File: enable high strictness level #21243

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Source File: enable high strictness level #21243

merged 2 commits into from
Jan 13, 2023

Conversation

roman-yermilov-gl
Copy link
Contributor

What

Enable high strictness level for SAT

@roman-yermilov-gl roman-yermilov-gl self-assigned this Jan 11, 2023
@roman-yermilov-gl roman-yermilov-gl linked an issue Jan 11, 2023 that may be closed by this pull request
Source File: enable high test strictness level in SAT #19076
Closed
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jan 11, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3891678874
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3891678874
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       283     40    86%
source_file/utils.py         13      5    62%
source_file/source.py        81     46    43%
---------------------------------------------
TOTAL                       379     91    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        81      7    91%
source_file/client.py       283     37    87%
---------------------------------------------
TOTAL                       379     45    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 26 passed, 3 skipped in 44.91s ========================

alafanechere
alafanechere approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@alafanechere alafanechere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling this! Could you please format your files to add the missing end lines?

airbyte-integrations/connectors/source-file/acceptance-test-config.yml Outdated Show resolved Hide resolved
@lazebnyi lazebnyi removed the request for review from girarda January 13, 2023 18:25
@lazebnyi lazebnyi merged commit b039a2c into master Jan 13, 2023
@lazebnyi lazebnyi deleted the ryermilov/source-file-enable-high-test-strictness-level branch January 13, 2023 18:49
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@roman-yermilov-gl @lazebnyi @jbfbell
Source File: enable high strictness level (#21243)
2196c7a 
* Source File: enable high strictness level

* Addedend line

Co-authored-by: Serhii Lazebnyi <[email protected]>
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere alafanechere approved these changes

@arsenlosenko arsenlosenko arsenlosenko approved these changes

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues connectors/source/file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source File: enable high test strictness level in SAT
6 participants
@roman-yermilov-gl @alafanechere @arsenlosenko @bazarnov @lazebnyi @octavia-squidington-iv