remove supportsNormalization + supportsDbt from sources spec #21317

alafanechere · 2023-01-12T14:29:41Z

What

Issue: https://github.com/airbytehq/airbyte-internal-issues/issues/2539
Some source connectors have supportsNormalization and supportsDbt fields.
These field are useless for sources and are now defined in destination definition.

How

Remove these fields from the spec.json file
Update the expected_spec.json used in testing.

github-actions · 2023-01-12T14:31:54Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (2)

Connector	Version	Changelog	Publish
`source-bigquery`	`0.2.3`	✅	✅
`source-kafka`	`0.2.3`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

…m-source-specs

alafanechere · 2023-01-12T14:36:14Z

/test connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3903235387
✅ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/3903235387
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:30: `future_state` not specified, skipping.
======================== 28 passed, 2 skipped in 54.27s ========================

alafanechere · 2023-01-12T14:36:23Z

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3903236825
❌ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/3903236825
🐛 https://gradle.com/s/m37uf7fqdu5je

Build Failed

Test summary info:

Could not find result summary

alafanechere · 2023-01-12T14:37:33Z

/test connector=connectors/source-elasticsearh

🕑 connectors/source-elasticsearh https://github.com/airbytehq/airbyte/actions/runs/3903246557
❌ connectors/source-elasticsearh https://github.com/airbytehq/airbyte/actions/runs/3903246557
🐛

Build Failed

Test summary info:

Could not find result summary

alafanechere · 2023-01-12T14:38:13Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/3903252855
❌ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/3903252855
🐛 https://gradle.com/s/u7gvorxzssuki

Build Failed

Test summary info:

Could not find result summary

alafanechere · 2023-01-12T14:39:11Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3903259819
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3903259819
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================= 13 passed, 6 skipped, 21 warnings in 17.66s ==================

alafanechere · 2023-01-12T14:39:32Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3903262669
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3903262669
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================= 13 passed, 6 skipped, 21 warnings in 18.40s ==================

alafanechere · 2023-01-12T14:39:40Z

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3903263561
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/3903263561
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 45.53s ==================

alafanechere · 2023-01-12T14:39:47Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3903263823
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3903263823
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:22: `future_state` has a bypass reason, skipping.
================== 54 passed, 6 skipped in 716.86s (0:11:56) ===================

alafanechere · 2023-01-12T14:40:14Z

/test connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/3903268600
✅ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/3903268600
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:30: `future_state` not specified, skipping.
================== 27 passed, 3 skipped in 167.90s (0:02:47) ===================

alafanechere · 2023-01-12T14:40:22Z

/test connector=connectors/source-sftp

🕑 connectors/source-sftp https://github.com/airbytehq/airbyte/actions/runs/3903268715
✅ connectors/source-sftp https://github.com/airbytehq/airbyte/actions/runs/3903268715
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 27.29s ==================

alafanechere · 2023-01-12T14:40:30Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3903268883
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3903268883
🐛 https://gradle.com/s/liql4zke4qoho

Build Failed

Test summary info:

Could not find result summary

alafanechere · 2023-01-12T14:40:42Z

/test connector=connectors/source-tidb

🕑 connectors/source-tidb https://github.com/airbytehq/airbyte/actions/runs/3903270722
✅ connectors/source-tidb https://github.com/airbytehq/airbyte/actions/runs/3903270722
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================= 13 passed, 6 skipped, 21 warnings in 16.57s ==================

alafanechere · 2023-01-12T14:42:57Z

@evantahler do I have to publish the connectors or only updating the source_spec.json file is OK?

evantahler

I think this PR and #21317 will have some collisions (e.g. both change airbyte-integrations/connectors/source-bigquery/src/main/resources/spec.json the same way).

We probably should publish the connectors (with a major semver bump + changelog entry like in #21317)

alafanechere · 2023-01-13T08:11:30Z

@evantahler I think you rather wanted to mention PR #21306 . The current PR is addressing source connectors only as the others are touching destinations.
I don't think the two fields I removed are used anywhere for sources, this I why I think it's safe to remove these without a major bump. I would also like to consider not publishing / version bumping these source connectors and only updating the source_spec.json. Wdyt?

alafanechere · 2023-01-13T12:48:19Z

For the same reasons I detailed here I think it's safe to merge these changes without version bump / publish.
These fields are moreover not used for sources in the platform.

…m-source-specs

github-actions · 2023-01-13T20:43:42Z

There is no coverage information present for the Files changed

Total Project Coverage	26.6%	🍏

…m-source-specs

github-actions · 2023-01-14T18:12:04Z

There is no coverage information present for the Files changed

Total Project Coverage	26.59%	🍏

remove supportsNormalization + supportsDbt from source spec

6baabd7

alafanechere temporarily deployed to more-secrets January 12, 2023 14:30 — with GitHub Actions Inactive

alafanechere temporarily deployed to more-secrets January 12, 2023 14:31 — with GitHub Actions Inactive

Merge branch 'master' into augustin/remove-supports-normalization-fro…

d6dc0f7

…m-source-specs

alafanechere marked this pull request as ready for review January 12, 2023 14:34

alafanechere requested a review from a team as a code owner January 12, 2023 14:34

alafanechere temporarily deployed to more-secrets January 12, 2023 14:36 — with GitHub Actions Inactive

alafanechere requested a review from a team January 12, 2023 14:41

evantahler reviewed Jan 12, 2023

View reviewed changes

Merge branch 'master' into augustin/remove-supports-normalization-fro…

07ce68b

…m-source-specs

alafanechere temporarily deployed to more-secrets January 13, 2023 12:52 — with GitHub Actions Inactive

alafanechere requested a review from evantahler January 13, 2023 13:47

alafanechere enabled auto-merge (squash) January 13, 2023 13:48

evantahler approved these changes Jan 13, 2023

View reviewed changes

Merge branch 'master' into augustin/remove-supports-normalization-fro…

b4ff5f7

…m-source-specs

alafanechere temporarily deployed to more-secrets January 13, 2023 20:32 — with GitHub Actions Inactive

alafanechere temporarily deployed to more-secrets January 13, 2023 20:33 — with GitHub Actions Inactive

Merge branch 'master' into augustin/remove-supports-normalization-fro…

85dbc57

…m-source-specs

alafanechere temporarily deployed to more-secrets January 14, 2023 18:01 — with GitHub Actions Inactive

alafanechere temporarily deployed to more-secrets January 14, 2023 18:02 — with GitHub Actions Inactive

alafanechere merged commit 0c8d6d3 into master Jan 14, 2023

alafanechere deleted the augustin/remove-supports-normalization-from-source-specs branch January 14, 2023 18:40

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove supportsNormalization + supportsDbt from sources spec #21317

remove supportsNormalization + supportsDbt from sources spec #21317

alafanechere commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading

✅ Sources (2)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023

evantahler left a comment •

edited

Loading

alafanechere commented Jan 13, 2023

alafanechere commented Jan 13, 2023

github-actions bot commented Jan 13, 2023

github-actions bot commented Jan 14, 2023

remove supportsNormalization + supportsDbt from sources spec #21317

remove supportsNormalization + supportsDbt from sources spec #21317

Conversation

alafanechere commented Jan 12, 2023 • edited Loading

What

How

github-actions bot commented Jan 12, 2023 • edited Loading

Affected Connector Report

✅ Sources (2)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Failed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Failed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Failed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Failed

alafanechere commented Jan 12, 2023 • edited by github-actions bot Loading

Build Passed

alafanechere commented Jan 12, 2023

evantahler left a comment • edited Loading

Choose a reason for hiding this comment

alafanechere commented Jan 13, 2023

alafanechere commented Jan 13, 2023

github-actions bot commented Jan 13, 2023

github-actions bot commented Jan 14, 2023

alafanechere commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

alafanechere commented Jan 12, 2023 •

edited by github-actions bot

Loading

evantahler left a comment •

edited

Loading