Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Move connection views and CreateConnection component to components/connection #21324

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

edmundito
Copy link
Contributor

What

Resolves #17155

This moves a few files related to connection:

  • All connection-related views are in components/connection
  • Moves CreateConnection component (now components/connection/CreateConnectionForm)
  • CollapsibleCard now part of components/ui and added storybook.

How

Moving files around, cleaning up imports

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 12, 2023
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have not tested locally but the build step would catch any errors from this work.

@edmundito edmundito enabled auto-merge (squash) January 18, 2023 16:17
@edmundito edmundito merged commit a0b6b9c into master Jan 18, 2023
@edmundito edmundito deleted the edmundito/move-ConnectionForm branch January 18, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Move connections components
3 participants