Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create connection page to full width, and fix trivial UI issues #21352

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Update create connection page to full width, and fix trivial UI issues #21352

merged 4 commits into from
Jan 13, 2023

Conversation

edmundito
Copy link
Contributor

What

Resolves #21338

Updates the create connection page screen full width on the create connection step (not the source or destination step). Additionally:

  • Updates the Normalizations & Transformations section heading to match the rest of the headings
  • Removes extra 20px padding from the Replication page
  • Adds page bottom padding to the FormPageContent layout

How

CSS changes

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 12, 2023
krishnaglick
krishnaglick approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@edmundito edmundito merged commit 55a4715 into master Jan 13, 2023
@edmundito edmundito deleted the edmundito/update-connection-create-page branch January 13, 2023 20:55
@edmundito edmundito mentioned this pull request Jan 13, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@edmundito @jbfbell
Update create connection page to full width, and fix trivial UI issues (
2256412 
#21352)

* Update big prop in FormPageContent to expand to full width

* Fix Normalization & Tranformation heading size

* Update FormPageContent to scss and add bottom padding

* Remove max-width from ConnectionReplicationPage
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update create connection page to fit new streams table
3 participants
@edmundito @krishnaglick @octavia-squidington-iv