🪟 🎉 Free Connectors Program large enrollment callout #21369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
2fad9be
to
076205c
Compare
teallarson
changed the title
teallarson
commented
Jan 13, 2023
| @@ -0,0 +1,667 @@ | |||
| <svg width="165" height="120" viewBox="0 0 165 120" fill="none" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
There was a problem hiding this comment.
It looks like this may be the same image @josephkmh used in #21396
Will adjust to use his instead once it's merged!
There was a problem hiding this comment.
Actually, this is a different image!
teallarson
changed the base branch from
master
to
teal/inline-alert-ab-connectors
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
810cc17
to
6c31bdb
Compare
teallarson
force-pushed
the
teal/inline-alert-ab-connectors
branch
from
6870736
to
e98af7c
Compare
teallarson
changed the title
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
6c31bdb
to
bed9a3d
Compare
teallarson
force-pushed
the
teal/inline-alert-ab-connectors
branch
from
9b77479
to
091cea4
Compare
josephkmh
reviewed
Jan 18, 2023
...ackages/cloud/components/experiments/FreeConnectorProgram/LargeEnrollmentCallout.module.scss
Show resolved
Hide resolved
...ackages/cloud/components/experiments/FreeConnectorProgram/LargeEnrollmentCallout.module.scss
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/CreditsPage.tsx
Outdated
Show resolved
Hide resolved
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
49a9732
to
f14ac81
Compare
teallarson
commented
Jan 18, 2023
Comment on lines
28
to
34
| const Block = styled.div` | ||
| background: ${({ theme }) => theme.blue50}; | ||
| border-radius: 8px; | ||
| padding: 18px 25px 22px; | ||
| padding: 15px 20px; | ||
| font-size: 13px; | ||
| line-height: 20px; | ||
| display: flex; |
There was a problem hiding this comment.
Worth converting this away from styled-components, use our actual variables, etc. ... but in the interest of getting this merged this AM that will be a separate PR!
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
7995c75
to
ca08552
Compare
josephkmh
approved these changes
Jan 18, 2023
Comment on lines
24
to
26
| const { data } = useFreeConnectorProgramInfo(); | ||
| const isFreeConnectorProgramEnabled = useExperiment("workspace.freeConnectorsProgram.visible", false); | ||
| const showEnrollmentUi = isFreeConnectorProgramEnabled && data?.showEnrollmentUi; |
There was a problem hiding this comment.
As mentioned on slack, I wonder if we can just roll the useExperiment() call into useFreeConnectorProgramInfo() so that data.showEnrollmentUi = false if the experiment is disabled.
teallarson
force-pushed
the
teal/large-enrollment-banner
branch
from
01e4972
to
5e9a4b4
Compare
ambirdsall
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #21223
How
Adds large banner and necessary assets
Recommended reading order
LargeEnrollmentBanner.*