Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector builder: Fix e2e tests #21380

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Connector builder: Fix e2e tests #21380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions airbyte-webapp/src/components/connectorBuilder/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
SubstreamSlicer,
SubstreamSlicerType,
CartesianProductStreamSlicer,
DeclarativeStreamSchemaLoader,
} from "core/request/ConnectorManifest";

export interface BuilderFormInput {
Expand Down Expand Up @@ -506,14 +507,16 @@ function builderFormStreamSlicerToStreamSlicer(
};
}

function parseSchemaString(schema?: string) {
const EMPTY_SCHEMA = { type: "InlineSchemaLoader", schema: {} };

function parseSchemaString(schema?: string): DeclarativeStreamSchemaLoader {
if (!schema) {
return undefined;
return EMPTY_SCHEMA;
}
try {
return { type: "InlineSchemaLoader", schema: JSON.parse(schema) };
} catch {
return undefined;
return EMPTY_SCHEMA;
}
}

Expand Down