Fix links in connector builder UI docs #21411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
the
area/documentation
sherifnada
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Do you know why this didn't break the docusaurus build?
It seems we already throw https://github.com/airbytehq/airbyte/blob/master/docusaurus/docusaurus.config.js#L16
Approving this PR assuming you tested it locally. But really this sort of bug shouldn't make it past CI. Could you create an issue for that?
|
left some context: https://airbytehq-team.slack.com/archives/C046KQF5GBT/p1673652656319819 |
|
Created an issue: https://github.com/airbytehq/airbyte-internal-issues/issues/2663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the broken links in the connector builder UI docs.
How
Apparently relative paths work differently in our docs page than they do in my local VS code markdown previewing tool. I've made these changes based on the locations that the links in our docs page was sending the user to, so they should be correct for that page.