Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Add api handlers for free connectors program #21414

Merged
merged 3 commits into from
Jan 17, 2023
Merged

🪟 🔧 Add api handlers for free connectors program #21414

merged 3 commits into from
Jan 17, 2023

Conversation

ambirdsall
Copy link
Contributor

@ambirdsall ambirdsall commented Jan 13, 2023 •
edited
Loading

What

Code to consume the new/updated APIs for the free connector program. Closes https://github.com/airbytehq/airbyte-cloud/issues/4006.

How

The code in .../cloud/lib/domain/freeConnectorProgram/api.ts was generated by pointing orval.config.ts at the airbyte-cloud openAPI spec file, then deleting all unrelated code. services/freeConnectorProgram.ts wraps it with the necessary config for easier use.

Recommended reading order

  • cloud/lib/domain/freeConnectorProgram/api.ts
  • cloud/services/freeConnectorProgram.ts

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 13, 2023
@ambirdsall ambirdsall force-pushed the alex/add-API-handlers-for-free-connectors-program branch 2 times, most recently from 228e25c to 5ce541f Compare January 13, 2023 19:57
@ambirdsall ambirdsall marked this pull request as ready for review January 13, 2023 19:57
josephkmh
josephkmh approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one suggestion about using useCurrentWorkspaceId()

airbyte-webapp/src/packages/cloud/services/freeConnectorProgram.ts Outdated Show resolved Hide resolved
@ambirdsall ambirdsall force-pushed the alex/add-API-handlers-for-free-connectors-program branch from 5ce541f to e14c593 Compare January 17, 2023 18:07
@ambirdsall ambirdsall force-pushed the alex/add-API-handlers-for-free-connectors-program branch from e14c593 to 56e4a96 Compare January 17, 2023 18:10
@ambirdsall
Copy link
Contributor Author

Pushed up some updates:

  1. updated the code to use useCurrentWorkspaceId
  2. moved the new files to within the cloud/components/experiments/FreeConnectorProgram/ directory
  3. Encapsulated the showEnrollmentUi logic within the useFreeConnectorProgramInfo hook
  4. Added a stubbed/hardcoded needsEmailVerification value to unblock building out conditional UI for that use case (cf. the discussion in this slack thread)

@ambirdsall ambirdsall changed the title Alex/add api handlers for free connectors program 🪟 🔧 Add api handlers for free connectors program Jan 17, 2023
@ambirdsall ambirdsall merged commit c830b7f into master Jan 17, 2023
@ambirdsall ambirdsall deleted the alex/add-API-handlers-for-free-connectors-program branch January 17, 2023 20:17
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson left review comments

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
airbyte-cloud area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ambirdsall @josephkmh @teallarson @octavia-squidington-iv