Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the OSS server only on OSS #21416

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

benmoriceau
Copy link
Contributor

What

The server endpoints are being declared twice in cloud because it depends on the server.
Ideally we should extract the handler in their own module and remove the dependency from the server wrapped to the server to avoid having requirement but this is a temporary since we will have one server soon. So the "dirty" solution is acceptable.

Without that the wrapped server can't run its health check properly because of:

benoit@Benoits-MacBook-Pro-2 ~/w/airbuild (master|✔) [7]> k exec airbyte-server-64cb54bb9b-qb8nf -- curl http://localhost:8001/api/v1/health
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0{"message":"Bad Request","_links":{"self":{"href":"/api/v1/health","templated":false}},"_embedded":{"errors":[{"message":"More than 1 100   262  100   262    0     0  36449      0 --:--:-- --:--:-- --:--:-- 43666h: GET - /api/v1/health, GET - /api/v1/health"}]}}

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Jan 13, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets January 13, 2023 19:20 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 13, 2023 19:21 — with GitHub Actions Inactive
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau
Copy link
Contributor Author

/approve-and-merge reason=”The kube acceptance test were successful but the test report failed"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants