Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Migrate from react-scripts to Vite #21421

Merged
merged 26 commits into from
Jan 23, 2023
Merged

🪟 🔧 Migrate from react-scripts to Vite #21421

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
0d8ffd9
Migrate to Vite
timroes Jan 13, 2023
71b2096
Continue work on vite migration
timroes Jan 13, 2023
146b855
More environment fixes
timroes Jan 13, 2023
507251a
Add CSP headers to dev server
timroes Jan 13, 2023
dfd92b6
Remove react-scripts
timroes Jan 13, 2023
33214a7
Shim process.env
timroes Jan 16, 2023
c604532
Cleanup
timroes Jan 16, 2023
ebb0fd4
Merge branch 'master' into tim/migrate-vite
timroes Jan 16, 2023
a6bd5be
Create ESLint failure for CI test
timroes Jan 17, 2023
4705784
Merge branch 'master' into tim/migrate-vite
timroes Jan 17, 2023
df8f641
create vite-plugins package
timroes Jan 17, 2023
7d25995
Update nodeJS
timroes Jan 17, 2023
e2ef1ab
Make eslint warnings fail build
timroes Jan 17, 2023
5b3c6f3
Merge branch 'master' into tim/migrate-vite
timroes Jan 17, 2023
891c0de
Remove trailing empty line in nvmrc
timroes Jan 17, 2023
bbb4e25
Match package.json with nvmrc
timroes Jan 17, 2023
45f28a2
Fix eslint test breakage
timroes Jan 17, 2023
c4dd5a2
Revert node upgrade
timroes Jan 17, 2023
d80c310
Merge branch 'master' into tim/migrate-vite
timroes Jan 19, 2023
3332a83
Merge branch 'master' into tim/migrate-vite
timroes Jan 20, 2023
d17829b
Remove setupProxy script
timroes Jan 20, 2023
7fabb5e
Change default API endpoints to be http
timroes Jan 20, 2023
d2d940c
Merge branch 'master' into tim/migrate-vite
timroes Jan 23, 2023
b47fffe
Merge branch 'master' into tim/migrate-vite
timroes Jan 23, 2023
dd7941e
Merge branch 'master' into tim/migrate-vite
timroes Jan 23, 2023
5b4e963
Merge branch 'master' into tim/migrate-vite
timroes Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions airbyte-webapp/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,8 @@ task copyNginx(type: Copy) {
into "build/docker/bin/nginx"
}

task stylelint(type: NpmTask) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Stylelint now runs as part of the Vite (via the checker plugin). So it doesn't need a separate Gradle task anymore.

dependsOn npmInstall
args = ['run', 'stylelint']
inputs.files commonConfigs
inputs.file '.stylelintrc'
inputs.dir 'src'
}

// Those tasks should be run as part of the "check" task
check.dependsOn validateLinks, licenseCheck, test, stylelint
check.dependsOn validateLinks, licenseCheck, test

build.dependsOn buildStorybook

Expand Down
26 changes: 0 additions & 26 deletions airbyte-webapp/craco.config.js
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions airbyte-webapp/public/index.html → airbyte-webapp/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,27 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="Airbyte is the turnkey open-source data integration platform that syncs data from applications, APIs and databases to warehouses."
/>
<meta name="airbyte:sec-token" value="c82db11b-64df-413d-aba8-ee66b99c046f" />
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<link rel="stylesheet" href="%PUBLIC_URL%/index.css">
<link rel="apple-touch-icon" href="/logo192.png" />
<link rel="manifest" href="/manifest.json" />
<link rel="stylesheet" href="/index.css">
<title>Airbyte</title>
</head>
<body>
<noscript>
<img src="%PUBLIC_URL%/logo.png" alt="" width="90" height="94"/>
<img src="/logo.png" alt="" width="90" height="94"/>
<div class="card">
You need to enable JavaScript to run this app.
</div>
</noscript>
<div id="root"></div>
<script type="module" src="/src/index.tsx"></script>
</body>
</html>
Loading