Fix table alignment issues in new streams table #21425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…destination + icon. Removed unnecessary loading of source and destination definitions
edmundito
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To verify these fixes please test with
REACT_APP_NEW_STREAMS_TABLE=trueWhat
Resolves #21387
Added some padding to the new streams table so the far right doesn't look as strange.
Separated out the styling for the destination header section (includes the arrow), and the destination + icon section.
Removed unnecessary calls to source and destination definition as the icon is available on the base object.
How
Flex grow and flex basis are set to highly specific values so it scales properly.