Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Run FE e2e tests on separate runner #21428

Merged
merged 3 commits into from
Jan 16, 2023
Merged

🪟 🔧 Run FE e2e tests on separate runner #21428

merged 3 commits into from
Jan 16, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Jan 13, 2023

What

This runs the frontend end2end tests on a separate runner, so the Frontend Build and End2End test shop won't be serialized anymore (as they are today), but instead can run in parallel, since they have no need for serialization.

@timroes timroes temporarily deployed to more-secrets January 13, 2023 21:20 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 13, 2023 21:20 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 16, 2023 09:33 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 16, 2023 09:34 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

josephkmh
josephkmh approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just had one suggestion to make the test workflow more explicit

.github/workflows/gradle.yml Outdated Show resolved Hide resolved
@timroes timroes temporarily deployed to more-secrets January 16, 2023 15:48 — with GitHub Actions Inactive
@timroes timroes temporarily deployed to more-secrets January 16, 2023 15:49 — with GitHub Actions Inactive
davinchia
davinchia approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timroes sorry I haven't had time to follow up yet. Busy with the performance work and roadmap planning!

@timroes timroes merged commit cb31ff5 into master Jan 16, 2023
@timroes timroes deleted the tim/fe-e2e-runner branch January 16, 2023 21:15
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephkmh josephkmh josephkmh approved these changes

@davinchia davinchia davinchia approved these changes

@ambirdsall ambirdsall Awaiting requested review from ambirdsall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @josephkmh @davinchia