Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connector builder documentation link again #21441

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Jan 14, 2023

What

(Hopefully) fix link again.

How

For some reason, our production docs.airbyte.com doesn't seem to like relative links of the form ./<path>. This works when testing docusaurus locally, but when it is deployed to our docs page, the link behaves incorrectly.

This PR avoids the ./ path completely by walking up one level and then back down to into /config-based to get to the right path. This also works locally, and other links using ../ work correctly on docs.airbyte.com, so hopefully this solution will work fine.

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 14, 2023
@lmossman lmossman merged commit 08207e2 into master Jan 14, 2023
@lmossman lmossman deleted the lmossman/fix-one-more-link branch January 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants