Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return stacktrace as part of the response #21443

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Don't return stacktrace as part of the response #21443

merged 2 commits into from
Jan 14, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Jan 14, 2023 •
edited
Loading

What

  • Remove the stacktrace from the connector builder's error response

Before
Screen Shot 2023-01-13 at 5 27 16 PM

After:
Screen Shot 2023-01-13 at 5 38 21 PM

@girarda girarda temporarily deployed to more-secrets January 14, 2023 01:41 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 14, 2023 01:41 — with GitHub Actions Inactive
@girarda girarda marked this pull request as ready for review January 14, 2023 01:45
@girarda girarda requested a review from lmossman January 14, 2023 01:45
@girarda girarda temporarily deployed to more-secrets January 14, 2023 01:46 — with GitHub Actions Inactive
@girarda girarda temporarily deployed to more-secrets January 14, 2023 01:47 — with GitHub Actions Inactive
lmossman
lmossman approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brianjlai
brianjlai approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions
Copy link
Contributor

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

1 similar comment
@github-actions
Copy link
Contributor

There is no coverage information present for the Files changed

Total Project Coverage 26.59% 🍏

@lmossman lmossman mentioned this pull request Jan 14, 2023
Merged
@girarda girarda merged commit 7f43da3 into master Jan 14, 2023
@girarda girarda deleted the alex/log_errors branch January 14, 2023 19:27
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman lmossman approved these changes

@brianjlai brianjlai brianjlai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@girarda @lmossman @brianjlai