🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues #21450

etsybaev · 2023-01-14T18:51:21Z

What

The Check method currently doesn't properly verify staging for GCS and S3.

How

Updated gcs and s3 staging check methods to handle more errors.

Tested locally on UI:

Attempts with invalid creds:

Attempts with valid creds:

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

github-actions · 2023-01-14T18:53:25Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (27)

Connector	Version	Changelog	Publish
`destination-azure-blob-storage`	`0.1.6`	✅	✅
`destination-bigquery`	`1.2.11`	✅	✅
`destination-bigquery-denormalized`	`1.2.11`	✅	✅
`destination-clickhouse`	`0.2.2`	❌ (changelog missing)	✅
`destination-clickhouse-strict-encrypt`	`0.2.2`	🔵 (ignored)	🔵 (ignored)
`destination-databricks`	`0.3.1`	✅	✅
`destination-dynamodb`	`0.1.7`	✅	✅
`destination-gcs`	`0.2.12`	✅	✅
`destination-jdbc`	`0.3.14`	🔵 (ignored)	🔵 (ignored)
`destination-mariadb-columnstore`	`0.1.7`	✅	✅
`destination-mssql`	`0.1.22`	✅	✅
`destination-mssql-strict-encrypt`	`0.1.22`	🔵 (ignored)	🔵 (ignored)
`destination-mysql`	`0.1.20`	✅	✅
`destination-mysql-strict-encrypt`	❌ `0.1.21` (mismatch: `0.1.20`)	🔵 (ignored)	🔵 (ignored)
`destination-oracle`	`0.1.19`	✅	✅
`destination-oracle-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`destination-postgres`	`0.3.26`	✅	✅
`destination-postgres-strict-encrypt`	`0.3.26`	🔵 (ignored)	🔵 (ignored)
`destination-r2`	`0.1.0`	✅	✅
`destination-redshift`	`0.3.53`	✅	✅
`destination-rockset`	`0.1.4`	✅	✅
`destination-s3`	`0.3.18`	✅	✅
`destination-s3-glue`	`0.1.1`	✅	✅
`destination-snowflake`	`0.4.43`	✅	✅
`destination-teradata`	`0.1.0`	✅	✅
`destination-tidb`	`0.1.0`	✅	✅
`destination-yugabytedb`	`0.1.0`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

etsybaev · 2023-01-14T18:59:19Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3919863900
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3919863900
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

etsybaev · 2023-01-18T18:28:39Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3951819313
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3951819313
🐛

github-actions · 2023-01-19T22:18:32Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	26.75%	🍏

etsybaev · 2023-01-20T09:55:49Z

/publish connector=connectors/destination-snowflake

🕑 Publishing the following connectors:
connectors/destination-snowflake
https://github.com/airbytehq/airbyte/actions/runs/3966556182

Connector	Did it publish?	Were definitions generated?
connectors/destination-snowflake	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…ssible s3 and gcs stagings issues

octavia-squidington-iv added area/connectors Connector related issues connectors/destination/snowflake connectors/destination/jdbc labels Jan 14, 2023

etsybaev linked an issue Jan 14, 2023 that may be closed by this pull request

Destination Snowflake: check does not verify GCS staging behavior #18312

Closed

etsybaev temporarily deployed to more-secrets January 14, 2023 18:53 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 14, 2023 18:54 — with GitHub Actions Inactive

etsybaev changed the title ~~[18312] Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues~~ Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues Jan 14, 2023

etsybaev marked this pull request as ready for review January 14, 2023 20:21

etsybaev requested a review from a team as a code owner January 14, 2023 20:21

etsybaev changed the title ~~Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues~~ 🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues Jan 14, 2023

grishick approved these changes Jan 17, 2023

View reviewed changes

etsybaev temporarily deployed to more-secrets January 18, 2023 18:15 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 18, 2023 20:28 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 19, 2023 09:37 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 19, 2023 17:01 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 19, 2023 21:14 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 19, 2023 22:07 — with GitHub Actions Inactive

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 20, 2023

etsybaev temporarily deployed to more-secrets January 20, 2023 09:35 — with GitHub Actions Inactive

etsybaev enabled auto-merge (squash) January 20, 2023 11:21

octavia-squidington-iii temporarily deployed to more-secrets January 20, 2023 11:23 — with GitHub Actions Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 20, 2023 13:08 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 20, 2023 14:13 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 20, 2023 15:46 — with GitHub Actions Inactive

etsybaev temporarily deployed to more-secrets January 20, 2023 16:54 — with GitHub Actions Inactive

etsybaev and others added 5 commits January 20, 2023 14:01

[18312] Destination-Snowflake: updated check method to handle more po…

1264a39

…ssible s3 and gcs stagings issues

fixed tests and codestyle

f8d9a57

fixed codestyle

472445b

bumped version

0048eb2

auto-bump connector version

d88f89b

grishick force-pushed the etsybaev/18312-destination-snowflake-fix-staging-check-methods branch from 4d31fe5 to d88f89b Compare January 20, 2023 22:01

grishick temporarily deployed to more-secrets January 20, 2023 22:03 — with GitHub Actions Inactive

etsybaev merged commit 2d65d62 into master Jan 20, 2023

etsybaev deleted the etsybaev/18312-destination-snowflake-fix-staging-check-methods branch January 20, 2023 22:37

etsybaev linked an issue Jan 21, 2023 that may be closed by this pull request

Fix Snowflake tests on master #21607

Closed

etsybaev mentioned this pull request Jan 21, 2023

Fix Snowflake tests on master #21607

Closed

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues #21450

🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues #21450

etsybaev commented Jan 14, 2023 •

edited

Loading

github-actions bot commented Jan 14, 2023 •

edited

Loading

✅ Sources (0)

❌ Destinations (27)

👀 Other Modules (1)

Actionable Items

etsybaev commented Jan 14, 2023 •

edited by github-actions bot

Loading

etsybaev commented Jan 18, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 19, 2023

etsybaev commented Jan 20, 2023 •

edited by github-actions bot

Loading

🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues #21450

🐛Destination-Snowflake: updated check method to handle more possible s3 and gcs stagings issues #21450

Conversation

etsybaev commented Jan 14, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Jan 14, 2023 • edited Loading

Affected Connector Report

✅ Sources (0)

❌ Destinations (27)

👀 Other Modules (1)

Actionable Items

etsybaev commented Jan 14, 2023 • edited by github-actions bot Loading

Build Passed

etsybaev commented Jan 18, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 19, 2023

Airbyte Code Coverage

etsybaev commented Jan 20, 2023 • edited by github-actions bot Loading

etsybaev commented Jan 14, 2023 •

edited

Loading

github-actions bot commented Jan 14, 2023 •

edited

Loading

etsybaev commented Jan 14, 2023 •

edited by github-actions bot

Loading

etsybaev commented Jan 18, 2023 •

edited by github-actions bot

Loading

etsybaev commented Jan 20, 2023 •

edited by github-actions bot

Loading