Source Sentry: enable SAT high strictness #21459

arsenlosenko · 2023-01-16T14:20:05Z

What

Resolving:
#19073

How

Enable SAT high strictness by updating acceptance-test-config.yml to new format and adding expected records.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

arsenlosenko · 2023-01-16T14:44:16Z

/test connector=connectors/source-sentry

arsenlosenko · 2023-01-16T14:49:51Z

test job does not start as expected, will investigate an start it again later.

arsenlosenko · 2023-01-16T16:28:45Z

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/3932259745
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/3932259745
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       87     11    87%
-----------------------------------------------
TOTAL                         107     11    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 29 passed, 2 skipped in 44.34s ========================

evantahler

👍 in that I don't see any PII

For sentry, the most important streams are issues and events, which means that these streams are probably the most important to have example records.

There's a python quickstart which should walk you though the process of creating an issue

arsenlosenko · 2023-01-16T18:14:49Z

@evantahler understood, going to take a look at the doc you have provided and try to add data for those two streams

arsenlosenko · 2023-01-17T09:15:10Z

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/3937735485
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/3937735485
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       87     11    87%
-----------------------------------------------
TOTAL                         107     11    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 29 passed, 2 skipped in 46.22s ========================

arsenlosenko · 2023-01-17T09:32:12Z

@evantahler I have added sample data for issues and events streams as you requested, you can take a look again

evantahler

Thank you for seeding those important streams!

Source Sentry: enable SAT high strictness

4b7e1f7

arsenlosenko requested review from lazebnyi and darynaishchenko January 16, 2023 14:20

arsenlosenko self-assigned this Jan 16, 2023

arsenlosenko linked an issue Jan 16, 2023 that may be closed by this pull request

Source Sentry: enable high test strictness level in SAT #19073

Closed

octavia-squidington-iv added area/connectors Connector related issues connectors/source/sentry labels Jan 16, 2023

arsenlosenko requested a review from evantahler January 16, 2023 14:24

evantahler requested changes Jan 16, 2023

View reviewed changes

Add data from events and issues streams

b187733

lazebnyi approved these changes Jan 17, 2023

View reviewed changes

bazarnov requested a review from evantahler January 17, 2023 12:22

bazarnov approved these changes Jan 17, 2023

View reviewed changes

evantahler approved these changes Jan 18, 2023

View reviewed changes

arsenlosenko merged commit db17010 into master Jan 18, 2023

arsenlosenko deleted the arsenlosenko/source-sentry-high-strictness branch January 18, 2023 09:10

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Sentry: enable SAT high strictness #21459

Source Sentry: enable SAT high strictness #21459

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 16, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 17, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 17, 2023

evantahler left a comment

Source Sentry: enable SAT high strictness #21459

Source Sentry: enable SAT high strictness #21459

Conversation

arsenlosenko commented Jan 16, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 16, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

arsenlosenko commented Jan 16, 2023

arsenlosenko commented Jan 17, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Jan 17, 2023

evantahler left a comment

Choose a reason for hiding this comment

arsenlosenko commented Jan 16, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Jan 17, 2023 •

edited by github-actions bot

Loading