Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-webapp: use the supported field to define supportsNormalization #21472

Merged
merged 2 commits into from
Jan 18, 2023
Merged

airbyte-webapp: use the supported field to define supportsNormalization #21472

merged 2 commits into from
Jan 18, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 17, 2023 •
edited
Loading

What

Now that the normalizationConfig object has a supported required boolean property we can use it to define the supportsNormalization variable.

How

Update supportsNormalization declaration in ConnectionTransformationPage.tsx

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 17, 2023
@alafanechere alafanechere marked this pull request as ready for review January 17, 2023 09:25
@alafanechere alafanechere changed the title airbyte-webapp: use the supported field to define supports normalization airbyte-webapp: use the supported field to define supportsNormalization Jan 17, 2023
@alafanechere alafanechere requested review from a team January 17, 2023 09:26
@alafanechere alafanechere enabled auto-merge (squash) January 17, 2023 09:27
evantahler
evantahler approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alafanechere alafanechere merged commit 84c37ce into master Jan 18, 2023
@alafanechere alafanechere deleted the augustin/webapp/fix-supports-normalization branch January 18, 2023 00:09
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alafanechere @evantahler @octavia-squidington-iv