Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source GitHub: #970 handle 502 Bad Gateway #21481

Merged

Conversation

roman-yermilov-gl
Copy link
Contributor

What

Handle 502 Bad Gateway with proper message

How

If there is an 502 error then we try to do few more delayed requests and finally (if not succeeded) provide a client with proper log message

Recommended reading order

  1. x.java
  2. y.python

@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source GitHub oncall 970 handle 502 Source GitHub: #970 handle 502 Bad Gateway Jan 17, 2023
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need add record to change log

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jan 18, 2023

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3948742809
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3948742809
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/graphql.py           145      1    99%
source_github/streams.py           798     44    94%
source_github/source.py            106     25    76%
----------------------------------------------------
TOTAL                             9872     70    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 38 passed, 3 skipped in 375.55s (0:06:15) ===================

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 18, 2023
@roman-yermilov-gl
Copy link
Contributor Author

Need add record to change log

Done. I didn't do it before since I was waiting for another PR in which version also bumped to 0.3.12

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jan 19, 2023

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/3960435518


Connector Did it publish? Were definitions generated?
connectors/source-github

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2023 17:43 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2023 17:43 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.77% 🍏

@roman-yermilov-gl roman-yermilov-gl enabled auto-merge (squash) January 19, 2023 19:24
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-github-oncall-970-handle-502 branch from 0da9f18 to b57b455 Compare January 19, 2023 19:26
@roman-yermilov-gl roman-yermilov-gl merged commit d1688c7 into master Jan 19, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-github-oncall-970-handle-502 branch January 19, 2023 19:27
etsybaev pushed a commit that referenced this pull request Jan 19, 2023
* Source Github: handle 502 Bad Gateway with proper log message

* Source Github: bump version

* Source Github: update changelog for new 0.3.12 version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants