Remove unused protocol version envvar #21495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosusnp
requested review from
colesnodgrass,
jdpgrailsdev,
benmoriceau,
cgardens and
alovew
benmoriceau
reviewed
Jan 17, 2023
| @@ -312,12 +310,12 @@ public AirbyteVersion getAirbyteVersion() { | |||
|
|
|||
| @Override | |||
| public Version getAirbyteProtocolVersionMax() { | |||
| return new Version(getEnvOrDefault(AIRBYTE_PROTOCOL_VERSION_MAX, "0.3.0")); | |||
| return new Version("0.3.0"); | |||
There was a problem hiding this comment.
Micronaut is expecting an envvar in the server it default to those values. But I think that we should check is other micronaut application.yml also specify a default value and don't rely on the return of this value.
There was a problem hiding this comment.
There was a problem hiding this comment.
When we get rid of EnvConfigs we should directly use the values from the micronaut config. Not sure where we are on this, this is a quick fix to remove logging noise.
Airbyte Code Coverage
|
benmoriceau
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AIRBYTE_PROTOCOL_VERSION_MAXandAIRBYTE_PROTOCOL_VERSION_MINenvironment variables.How
Replace the var lookups by the hardcoded default directly to remove noise from the logs.