Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Mixpanel: enable high test strictness level in SAT #21510

Merged
merged 11 commits into from
Jan 25, 2023
Merged

Source Mixpanel: enable high test strictness level in SAT #21510

merged 11 commits into from
Jan 25, 2023

Conversation

lazebnyi
Copy link
Collaborator

#19056
SAT high strictness

@lazebnyi lazebnyi linked an issue Jan 18, 2023 that may be closed by this pull request
Source Mixpanel: enable high test strictness level in SAT #19056
Closed
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 18, 2023
@lazebnyi lazebnyi changed the title Source Mixpanel: enable high test strictness level in SAT Source Mixpanel: enable high test strictness level in SAT Jan 18, 2023
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 18, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3949820857

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 18, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3953454454
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3953454454
🐛

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 19, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3958414616

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 19, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3961768781

alafanechere
alafanechere approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice coverage, thank you!

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 24, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3995494782

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 24, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4001034948

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 25, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4006111716

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 25, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4008285123
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4008285123
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/utils.py                         8      0   100%
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              57      0   100%
source_mixpanel/streams/cohorts.py              15      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/streams/base.py                 89      2    98%
source_mixpanel/streams/export.py               68      3    96%
source_mixpanel/streams/engage.py               88      6    93%
source_mixpanel/source.py                       79     10    87%
source_mixpanel/streams/annotations.py          16      3    81%
source_mixpanel/streams/cohort_members.py       21      7    67%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          514     42    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 31 passed, 2 skipped in 4558.05s (1:15:58) ==================

@lazebnyi lazebnyi merged commit 6801049 into master Jan 25, 2023
@lazebnyi lazebnyi deleted the lazebnyi/19056-enable-high-test-strictness-level branch January 25, 2023 19:34
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere alafanechere approved these changes

@darynaishchenko darynaishchenko darynaishchenko approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Mixpanel: enable high test strictness level in SAT
4 participants
@lazebnyi @alafanechere @darynaishchenko @octavia-squidington-iv