Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Fix stream table heading design issues #21554

Merged
merged 3 commits into from
Jan 20, 2023
Merged

🪟 🎨 Fix stream table heading design issues #21554

merged 3 commits into from
Jan 20, 2023

Conversation

edmundito
Copy link
Contributor

What

  • Makes info icon 11px, which more closely matches design
  • Update table heading to use same components as stream details panel
  • Move checkbox to align horizontally with source icon

image

@edmundito edmundito self-assigned this Jan 18, 2023
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 18, 2023
krishnaglick
krishnaglick approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, did not test locally. Looks like there's some snapshot failures.

dizel852
dizel852 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally - works as expected
image

@edmundito edmundito enabled auto-merge (squash) January 20, 2023 19:44
@edmundito edmundito force-pushed the edmundito/fix-stream-table-headings branch from 548997e to 16bc32e Compare January 20, 2023 20:41
@edmundito edmundito merged commit 0562b96 into master Jan 20, 2023
@edmundito edmundito deleted the edmundito/fix-stream-table-headings branch January 20, 2023 21:06
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@dizel852 dizel852 dizel852 approved these changes

Assignees

@edmundito edmundito

Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundito @krishnaglick @dizel852 @octavia-squidington-iv