Source Instagram: test strictness level high #21602

davydov-d · 2023-01-19T15:36:02Z

What

Set high test strictness level of Instagram source

How

add expected records
fix minor bug
refactor test config file
add abnormal state
add incremental catalog

davydov-d · 2023-01-19T15:39:00Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3960006424
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3960006424
🐛 https://gradle.com/s/775e4altay5f6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream media...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:206: Skipping new incremental test based on acceptance-test-config.yml
============= 1 failed, 28 passed, 2 skipped in 390.78s (0:06:30) ==============

davydov-d · 2023-01-19T17:35:42Z

/test connector=connectors/source-instagram

davydov-d · 2023-01-19T17:56:02Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3961078670

davydov-d · 2023-01-20T11:36:00Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3967266046

davydov-d · 2023-01-20T11:57:38Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3967395223
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3967395223
🐛 https://gradle.com/s/urxgv66clrzbc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream users...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:206: Skipping new incremental test based on acceptance-test-config.yml
============= 1 failed, 28 passed, 2 skipped in 347.75s (0:05:47) ==============

davydov-d · 2023-01-20T13:35:53Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3968120396
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3968120396
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      205     94    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            333    132    60%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      205     20    90%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            333     30    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:206: Skipping new incremental test based on acceptance-test-config.yml
================== 29 passed, 2 skipped in 459.68s (0:07:39) ===================

evantahler

Assuming the business account ID is a sandbox account, 👍!

davydov-d · 2023-01-20T18:34:25Z

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/3970331842

Connector	Did it publish?	Were definitions generated?
connectors/source-instagram	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-01-20T19:18:35Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	26.72%	🍏

…ctness-level-high

#19049 source instagram: test strictness level high

39c03ad

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram labels Jan 19, 2023

#19049 source instagram - upd changelog

e980d1e

davydov-d requested review from darynaishchenko, lazebnyi and a team January 19, 2023 15:39

#19049 source instagram: upd expected records

cd5ed74

davydov-d removed the request for review from a team January 19, 2023 17:55

lazebnyi approved these changes Jan 19, 2023

View reviewed changes

darynaishchenko approved these changes Jan 20, 2023

View reviewed changes

#19049 sourcte instagram: update expected records

f8cd4d7

#19049 source instagram: exclude Media stream from sat

6430f81

#19049 source instagram: bypass users stream

b1681c4

davydov-d requested a review from a team January 20, 2023 14:02

evantahler approved these changes Jan 20, 2023

View reviewed changes

auto-bump connector version

8b5adb0

octavia-squidington-iii temporarily deployed to more-secrets January 20, 2023 19:07 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#19049-source-instagram-test-stri…

d11a465

…ctness-level-high

davydov-d temporarily deployed to more-secrets January 23, 2023 07:40 — with GitHub Actions Inactive

davydov-d merged commit b83cd57 into master Jan 23, 2023

davydov-d deleted the ddavydov/#19049-source-instagram-test-strictness-level-high branch January 23, 2023 08:18

davydov-d mentioned this pull request Jan 23, 2023

Source Instagram: enable high test strictness level in SAT #19049

Closed

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Instagram: test strictness level high #21602

Source Instagram: test strictness level high #21602

davydov-d commented Jan 19, 2023

davydov-d commented Jan 19, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 19, 2023

davydov-d commented Jan 19, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading

Source Instagram: test strictness level high #21602

Source Instagram: test strictness level high #21602

Conversation

davydov-d commented Jan 19, 2023

What

How

davydov-d commented Jan 19, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Jan 19, 2023

davydov-d commented Jan 19, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 20, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 20, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Jan 20, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

davydov-d commented Jan 20, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 20, 2023 • edited Loading

Airbyte Code Coverage

davydov-d commented Jan 19, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 19, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 20, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 20, 2023 •

edited

Loading