Source S3: keep processing but warn if OSError happen #21604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-yermilov-gl
requested review from
evantahler,
lazebnyi and
darynaishchenko
octavia-squidington-iv
added
area/connectors
|
/test connector=connectors/source-s3
Build PassedTest summary info: |
octavia-squidington-iv
added
the
area/documentation
evantahler
reviewed
Jan 19, 2023
Comment on lines
68
to
70
| self.logger.warn(f"We don't have access to {self.url}. " | ||
| f"Check whether key {self.url} exists in `{bucket}` bucket and/or has proper ACL permissions") | ||
| raise e |
There was a problem hiding this comment.
Does this produce an AirbyteTraceError message? Just logging to stdout won't help users learn what to do
There was a problem hiding this comment.
cc @brianjlai maybe you recall the answer - does throwing an exception here end up making a useable AirbyteTraceErrorMessage?
There was a problem hiding this comment.
It does. But in this case I catch it in two possible places where it can be raised and handle it
There was a problem hiding this comment.
Ok, this matches the philosophy that @erohmensing is working on with streams being unavailable - we sync what we can and log an error for the streams we can't reach. 👍
lazebnyi
approved these changes
Jan 19, 2023
darynaishchenko
approved these changes
Jan 20, 2023
|
/publish connector=connectors/source-s3
if you have connectors that successfully published but failed definition generation, follow step 4 here |
octavia-squidington-iii
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
octavia-squidington-iii
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
evantahler
approved these changes
Jan 23, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Handle OSError which means no access to key in a bucket. Warn and keep working on another files which we have an access to