Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jobPersistence dependency #21625

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Remove jobPersistence dependency #21625

merged 4 commits into from
Jan 21, 2023

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Jan 19, 2023

Remove jobPersistence from ConfigFetchActivityImpl and replace it with JobsAPI

@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker labels Jan 19, 2023
@alovew alovew temporarily deployed to more-secrets January 19, 2023 22:00 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 19, 2023 22:00 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [71.19%] 🍏
JobConverter.java 97.01% 🍏
JobHistoryHandler.java 86.22% 🍏
ConfigFetchActivityImpl.java 69.23% 🍏
ApiClientBeanFactory.java 0% ❌
JobsApiController.java 0% ❌
Total Project Coverage 26.72% 🍏

@alovew alovew temporarily deployed to more-secrets January 19, 2023 22:44 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 19, 2023 22:44 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 00:47 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 00:47 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 02:20 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 02:20 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 04:56 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 04:56 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 19:16 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 19:16 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 21:28 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 21:29 — with GitHub Actions Inactive
@alovew alovew force-pushed the anne/jobs-config-dependency branch from 52b7f2d to 8cc48de Compare January 20, 2023 23:14
@alovew alovew temporarily deployed to more-secrets January 20, 2023 23:16 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 20, 2023 23:16 — with GitHub Actions Inactive
@alovew alovew merged commit 6026465 into master Jan 21, 2023
@alovew alovew deleted the anne/jobs-config-dependency branch January 21, 2023 00:32
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@gosusnp gosusnp Awaiting requested review from gosusnp

Assignees
No one assigned
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alovew @jdpgrailsdev @benmoriceau @octavia-squidington-iv