Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all origin in cors #21668

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Allow all origin in cors #21668

merged 2 commits into from
Jan 20, 2023

Conversation

benmoriceau
Copy link
Contributor

What

Micronaut has some check in the CORS filter specifiv to the localhost. This will allow all the Cors requests, including the one coming from localhost.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Jan 20, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 18:02 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 18:02 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.75% 🍏

jdpgrailsdev
jdpgrailsdev approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 20:58 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 20, 2023 20:58 — with GitHub Actions Inactive
@benmoriceau benmoriceau merged commit 8531530 into master Jan 20, 2023
@benmoriceau benmoriceau deleted the bmoric/fix-cors branch January 20, 2023 22:19
@josephkmh josephkmh mentioned this pull request Jan 23, 2023
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmoriceau @jdpgrailsdev @octavia-squidington-iv