Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an npe on a sort fuction #21685

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fix an npe on a sort fuction #21685

merged 3 commits into from
Jan 23, 2023

Conversation

benmoriceau
Copy link
Contributor

What

An Npe exception during the sort of the release stages was causing confusing on build. This error was not terminal and would likely pass the test. This is filtering null values before sorting.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 21, 2023
@benmoriceau benmoriceau mentioned this pull request Jan 21, 2023
Merged
@benmoriceau benmoriceau temporarily deployed to more-secrets January 21, 2023 01:45 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 21, 2023 01:45 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cgardens
Copy link
Contributor

thanks @benmoriceau

@benmoriceau benmoriceau temporarily deployed to more-secrets January 21, 2023 15:08 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 21, 2023 15:08 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 23, 2023 16:14 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 23, 2023 16:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

File Coverage [83.69%] 🍏
JobCreationAndStatusUpdateActivityImpl.java 83.69% 🍏
Total Project Coverage 26.72% 🍏

@benmoriceau benmoriceau enabled auto-merge (squash) January 23, 2023 16:46
@benmoriceau benmoriceau merged commit b8d5471 into master Jan 23, 2023
@benmoriceau benmoriceau deleted the bmoric/fix-npe branch January 23, 2023 16:50
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@cgardens cgardens cgardens approved these changes

@evantahler evantahler Awaiting requested review from evantahler

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benmoriceau @cgardens @jdpgrailsdev @octavia-squidington-iv