Connector builder server: Pin cdk version #21708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
clnoll
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
LGTM @flash1293 - makes sense that we'd want to do this so we can be more careful as we roll out updates to the connector builder.
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
flash1293
deleted the
flash1293/pin-connector-builder-server-cdk-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small adjustment of the dependencies of the connector builder server. Right now the connector builder server is implicitly using the latest version of the CDK. This can lead to broken CI on master as the connector builder server is not automatically rebuilt if the CDK changes, so potential breakages would not be caught in time.
This PR pins the cdk dependency down to the patch version so updating it will touch the connector builder server code and run its tests to make sure the upgrade will actually work.
Another approach would be to automatically test the connector builder server with the current state of cdk as part of CI on the PR itself, but this has several disadvantages:
Just putting this into place for now, but happy to discuss and revisit later on.