Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes in dropdowns now correctly visually update when clicked #21725

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

krishnaglick
Copy link
Contributor

What

Resolves #21707
Checkboxes in the select dropdown triggered logic, but did not cause a visual change.

How

preventDefault causes the checkboxes to stop toggling themselves and to instead only toggle based on the data.

Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally 👍

@krishnaglick krishnaglick merged commit 3b1864f into master Jan 23, 2023
@krishnaglick krishnaglick deleted the kc/fix-dropdown-checkboxes branch January 23, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PathPopout dropdown checkboxes not working as expected
2 participants