🪟 🐛 Hide anonymize data field on preference page #21733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #21053
This will make sure to hide the "anaonymize data" checkbox in the initial setup screen on OSS, if logging via Segment has actually be turned of completely, to not confuse the user.
We set the
anonymizeDataCollection
flag in the workspace totrue
in this case, so in case the user ever enabled logging later (by removing the correspondingTRACKING_STRATEGY
from their.env
file), they'll still have anonymized data collection, since we never gave them the choice for it otherwise. (I imagine that to anyway be a very edge-case that a user turns it on initially and then turn it off later after having gone through preference.)Best to reviewed with "ignore whitespaces".