Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Hide anonymize data field on preference page #21733

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Jan 23, 2023

What

Fixes #21053

This will make sure to hide the "anaonymize data" checkbox in the initial setup screen on OSS, if logging via Segment has actually be turned of completely, to not confuse the user.

We set the anonymizeDataCollection flag in the workspace to true in this case, so in case the user ever enabled logging later (by removing the corresponding TRACKING_STRATEGY from their .env file), they'll still have anonymized data collection, since we never gave them the choice for it otherwise. (I imagine that to anyway be a very edge-case that a user turns it on initially and then turn it off later after having gone through preference.)

Best to reviewed with "ignore whitespaces".

@timroes timroes added type/enhancement New feature or request team/compose area/frontend Related to the Airbyte webapp labels Jan 23, 2023
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is there anything to take care of with regards to workspaces that were set up before this change and had it default to false?

Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Agreed that enabling logging later and wanting to change anonymization settings would be an extreme edge case.

@timroes
Copy link
Collaborator Author

timroes commented Jan 25, 2023

Is there anything to take care of with regards to workspaces that were set up before this change and had it default to false?

@tealjulia Workspaces that were setup beforehand even had the chance to select this flag (even if they had the segment integration off altogether), so I think we're fine here, with whatever they chose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/compose type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disambiguate Telemetry Opt-out
3 participants