Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticate when calling setup-python #21741

Merged
merged 2 commits into from
Jan 23, 2023
Merged

authenticate when calling setup-python #21741

merged 2 commits into from
Jan 23, 2023

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jan 23, 2023

What

We have two problems currently

  1. We call setup-python 9 times in our airbyte ci workflow. That's a LOT of downloading of basically the same files over and over
  2. setup-python auth's using GITHUB_TOKEN if you don't specify a token. This is causing rate limit issues. We want to instead use a PAT to auth which has higher rate limits.

How

Solve 2 because it's a quick fix. Acknowledge 1 needs to be solved either by caching or some other solution. Other setup-platform actions like setup-node have fallbacks to hit other places but it doesn't look like the team behind setup-python are interested in adding that functionality to their action, unfortunately.

@c-p-b c-p-b temporarily deployed to more-secrets January 23, 2023 19:21 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 23, 2023 19:21 — with GitHub Actions Inactive
@c-p-b c-p-b enabled auto-merge (squash) January 23, 2023 19:27
@c-p-b c-p-b requested a review from a team January 23, 2023 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.7% 🍏

git-phu
git-phu approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@git-phu git-phu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working in this PR run, seems legit

unfortunately the log output doesn't indicate that we're using a PAT now, but seems like it should be

@c-p-b
Copy link
Contributor Author

c-p-b commented Jan 23, 2023

working in this PR run, seems legit

unfortunately the log output doesn't indicate that we're using a PAT now, but seems like it should be

Yeah the behavior of this action is very under-the-hood, i had to dig into their source code and issues to even figure out that they were using tokens and authing to github. That "token" option isn't really front and center on their README

@c-p-b c-p-b temporarily deployed to more-secrets January 23, 2023 19:55 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets January 23, 2023 19:55 — with GitHub Actions Inactive
@c-p-b c-p-b merged commit b7685a7 into master Jan 23, 2023
@c-p-b c-p-b deleted the auth-setup-python branch January 23, 2023 20:30
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-phu git-phu git-phu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-p-b @git-phu