Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return set of role labels #21751

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Return set of role labels #21751

merged 2 commits into from
Jan 24, 2023

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Improve the convenience of building role hierarchy

How

  • Return a set of role labels as strings instead of as AuthRole objects.

Recommended reading order

  1. AuthRole.java

Tests

  • Existing unit test updated
  • All other unit tests pass
  • Project builds locally

@jdpgrailsdev jdpgrailsdev requested a review from a team as a code owner January 23, 2023 22:07
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 23, 2023 22:09 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 23, 2023 22:09 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [100%] 🍏
AuthRole.java 100% 🍏
Total Project Coverage 26.71% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Platform Test Results

   233 files  ±0     233 suites  ±0   29m 24s ⏱️ + 3m 54s
1 610 tests ±0  1 599 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
1 630 runs  ±0  1 619 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit e8aac18. ± Comparison against base commit 9e15045.

♻️ This comment has been updated with latest results.

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 24, 2023 14:48 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 24, 2023 14:48 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev merged commit 62c0972 into master Jan 24, 2023
@jdpgrailsdev jdpgrailsdev deleted the jonathan/get-auth-role-labels branch January 24, 2023 15:33
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Closed
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@gosusnp gosusnp Awaiting requested review from gosusnp

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdpgrailsdev @benmoriceau