🪟 🎉 Log out if a user logs out of another tab #21766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambirdsall
approved these changes
Jan 26, 2023
josephkmh
approved these changes
Jan 27, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes https://github.com/airbytehq/airbyte-cloud/issues/3735
Previously, a user could click in the UI and end up with an error screen if they logged out in another tab.
Now, we log out and redirect to sign-in screen immediately if user logs out in another tab
How
Firebase already watches for updates consistently, so added a check in our Service for a logged in user. If there is none, tell the reducer.
The flow for automatically logging in from another tab is proving a bit touchier and thus will be solved in a separate PR as it requires some more digging.
Recommended reading order
Testing
Manual testing: