Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sentry: add state persistence #21864

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Jan 25, 2023

What

https://github.com/airbytehq/oncall/issues/1317

How

Add state persistence for incremental streams

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues connectors/source/sentry area/documentation Improvements or additions to documentation labels Jan 25, 2023
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jan 25, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4008641571
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4008641571
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       93     14    85%
-----------------------------------------------
TOTAL                         113     14    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 29 passed, 2 skipped in 45.90s ========================

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work.
Storing stage is important 😓

We'll add a better test for this to SAT via #21863

@davydov-d
Copy link
Collaborator

davydov-d commented Jan 26, 2023

/publish connector=connectors/source-sentry

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator

davydov-d commented Jan 26, 2023

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/4014401161


Connector Did it publish? Were definitions generated?
connectors/source-sentry

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d changed the title Ryermilov/source sentry add state persistence Source Sentry: add state persistence Jan 26, 2023
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2023 11:07 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2023 11:08 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 23.97%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants