Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Update eslint and add dependencies explicitly #21868

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Jan 25, 2023

What

This PR is in preparation to switch us to pnpm. It does the following three things:

  • Adding all dependencies we're using explicitly to package.json instead of relying on them being pulled in by other packages.
  • This came with an update to the import/order rule, which sorts relative imports slightly differently now. Thus I wanted to pull this into a separate PR, since I --fixed all files in validation of this.
  • Due to the new dependencies installed, npm (un)flattens packages in a way that a prior typing conflict is now resolved, thus removed two @ts-expect-error statements. (Makes the point perfectly why we should switch to pnpm :D)

Only the package.json was touched manually, the rest is all just auto fixed by ESLint.

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 25, 2023
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick scan of the eslint fixes and it all looks fine 🙂

Copy link
Contributor

@letiescanciano letiescanciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants