Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-Code CDK: SubstreamSlicer.parent_key - dpath support added #21900

Merged
merged 11 commits into from
Jan 31, 2023
Merged

Low-Code CDK: SubstreamSlicer.parent_key - dpath support added #21900

merged 11 commits into from
Jan 31, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jan 26, 2023 •
edited
Loading

Signed-off-by: Sergey Chvalyuk [email protected]

What

  • Make SubstreamSlicer.parent_key, SubstreamSlicer.stream_slice_field as InterpolatedString
  • SubstreamSlicer.parent_key supports dpath now
  • if SubstreamSlicer.parent_key not found in parent object skip slice record

@grubberr
substream_slicer - dpath added
4fc15a8 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr requested a review from a team as a code owner January 26, 2023 05:54
@grubberr grubberr self-assigned this Jan 26, 2023
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Jan 26, 2023
@grubberr
CHANGELOG.md updated
d0aa59d 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
bump 0.23.1
4663db5 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
Merge branch 'master' into grubberr/cdk-declarative-fix-substream-slicer
7767368 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
dpath 2.1.4 -> 2.0.1
98930cd 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
code lint
28d6395 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
test_missed_parent_key added
9685b4e 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr
test_dpath_extraction added
3355664 
Signed-off-by: Sergey Chvalyuk <[email protected]>
@sherifnada sherifnada removed the request for review from alafanechere January 31, 2023 06:43
@lazebnyi lazebnyi requested a review from girarda January 31, 2023 10:14
brianjlai
brianjlai approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. nice work! Were there any specific connectors that were blocked on the substream slicer lacking these two features?

@grubberr
Copy link
Contributor Author

@brianjlai thank you
I am working on migration source-twilio to low-code
#21446

@grubberr grubberr merged commit 66b8f5a into master Jan 31, 2023
@grubberr grubberr deleted the grubberr/cdk-declarative-fix-substream-slicer branch January 31, 2023 17:09
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

@girarda girarda Awaiting requested review from girarda

Assignees

@grubberr grubberr

Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grubberr @brianjlai @octavia-squidington-iv